Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datamap only as its own file? #134

Open
HLWeil opened this issue Feb 12, 2025 · 2 comments · May be fixed by #142
Open

Datamap only as its own file? #134

HLWeil opened this issue Feb 12, 2025 · 2 comments · May be fixed by #142
Labels
Status: Needs Triage This item is up for investigation.

Comments

@HLWeil
Copy link
Member

HLWeil commented Feb 12, 2025

Currently, Datamaps can either be specified as their own file or as a sheet in an assay or study.

This was meant as a goodie for user choice, but causes a lot of trouble in the implementations (as usual with information duplication). Maybe we should just stick to one of the two options?

@Freymaurer @muehlhaus @feserm @Brilator
@github-actions github-actions bot added the Status: Needs Triage This item is up for investigation. label Feb 12, 2025
@Brilator
Copy link
Member

Own file sounds reasonable to me as (i) it's a larger deviation from / addition to original ISA and (ii) may independently be of use (i.e. data dictionary to an external dataset imported to an ARC).

@HLWeil HLWeil linked a pull request Feb 28, 2025 that will close this issue
Open
@HLWeil
Copy link
Member Author

HLWeil commented Mar 5, 2025

Meeting Notes from 05.03.2025:

  • Datamap only as its own file
  • Datamap can be part of every main-entity subfolder (assay, study, run, workflow)
  • Multiple Worksheets (?)
  • Tooling guidance:
    • Swate handles Datamap as its own file
    • Remove Datamap sheet from Assay editor
    • ARCitect displays Datamap as its own file (in Assay Folder) and supports CRUDE operations on it
    • ARCitect clicking on Datamap opens Datamap view in Swate
    • ARCtrl prioritizes read from file over deprecated read from sheet

Other discussion points:

  • Place Datamaps anywhere? No, because we want to limit the degrees of freedom to an extent where different users understand each others work based on the limits of the specification
  • ARCtrl: Move Datamaps out of Assay/Study? No(ish), Assay and Study files are anyways required by ARC spec, and tool handling Datamap and Assay separately is technically not a big deal

@Brilator Brilator mentioned this issue Mar 6, 2025
Open
This was referenced Mar 6, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Status: Needs Triage This item is up for investigation.
Projects
ARCStack
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow datamap only as own file nfdi4plants/ARC-specification
2 participants
@Brilator @HLWeil