From 5ef1bcd5159c250b21a8158f05a61df31a4a7e31 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 18:14:02 +0100 Subject: [PATCH 1/7] Remove Twitter links --- README.Rmd | 16 ++++++++-------- README.md | 37 ++++++++++++++----------------------- 2 files changed, 22 insertions(+), 31 deletions(-) diff --git a/README.Rmd b/README.Rmd index 8b22abe0..9f3d8086 100644 --- a/README.Rmd +++ b/README.Rmd @@ -20,8 +20,8 @@ knitr::opts_chunk$set( [![CRAN downloads](http://cranlogs.r-pkg.org/badges/grand-total/nflfastR)](https://CRAN.R-project.org/package=nflfastR) [![Travis build status](https://travis-ci.com/mrcaseb/nflfastR.svg?branch=master)](https://travis-ci.com/mrcaseb/nflfastR) [![R build status](https://github.com/mrcaseb/nflfastR/workflows/R-CMD-check/badge.svg)](https://github.com/mrcaseb/nflfastR/actions) -[![Discord Chat](https://img.shields.io/discord/308323056592486420.svg)](https://discord.gg/5Er2FBnnQa) -[![Twitter Follow](https://img.shields.io/twitter/follow/nflfastR.svg?style=social)](https://twitter.com/nflfastR) +[![Discord Chat](https://img.shields.io/discord/308323056592486420.svg)](https://discord.com/invite/5Er2FBnnQa) + @@ -148,11 +148,11 @@ knitr::include_graphics('https://github.com/mrcaseb/nflfastR/raw/master/man/figu ## Special thanks -* To [Nick Shoemaker](https://twitter.com/WeightRoomShoe) for [finding and making available JSON-formatted NFL play-by-play back to 1999](https://github.com/CroppedClamp/nfl_pbps) (`nflfastR` uses this source for 1999 and 2000 and previously also used it for 2001-2010) -* To [Lau Sze Yui](https://twitter.com/903124S) for developing a scraping function to access JSON-formatted NFL play-by-play beginning in 2001. -* To [Lee Sharpe](https://twitter.com/LeeSharpeNFL) for curating a resource for game information -* To [Timo Riske](https://twitter.com/PFF_Moo), [Lau Sze Yui](https://twitter.com/903124S), [Sean Clement](https://twitter.com/SeanfromSeabeck), and [Daniel Houston](https://twitter.com/CowboysStats) for many helpful discussions regarding the development of the new `nflfastR` models -* To [Zach Feldman](https://twitter.com/ZachFeldman3) and [Josh Hermsmeyer](https://twitter.com/friscojosh) for many helpful discussions about CPOE models as well as [Peter Owen](https://twitter.com/JSmoovesBrekkie) for [many helpful suggestions for the CP model](https://twitter.com/JSmoovesBrekkie/status/1268885950626623490) -* To [Florian Schmitt](https://twitter.com/Flosch1006) for the logo design +* To Nick Shoemaker for [finding and making available JSON-formatted NFL play-by-play back to 1999](https://github.com/CroppedClamp/nfl_pbps) (`nflfastR` uses this source for 1999 and 2000 and previously also used it for 2001-2010) +* To Lau Sze Yui for developing a scraping function to access JSON-formatted NFL play-by-play beginning in 2001. +* To Lee Sharpe for curating a resource for game information +* To Timo Riske, Lau Sze Yui, Sean Clement, and Daniel Houston for many helpful discussions regarding the development of the new `nflfastR` models +* To Zach Feldman and Josh Hermsmeyer for many helpful discussions about CPOE models as well as Peter Owen for many helpful suggestions for the CP model +* To Florian Schmitt for the logo design * The many users who found and reported bugs in `nflfastR` 1.0 * And of course, the original [`nflscrapR`](https://github.com/maksimhorowitz/nflscrapR) team, Maksim Horowitz, Ronald Yurko, and Samuel Ventura, whose work represented a dramatic step forward for the state of public NFL research diff --git a/README.md b/README.md index 542fc711..1787815b 100644 --- a/README.md +++ b/README.md @@ -14,9 +14,8 @@ status](https://travis-ci.com/mrcaseb/nflfastR.svg?branch=master)](https://travi [![R build status](https://github.com/mrcaseb/nflfastR/workflows/R-CMD-check/badge.svg)](https://github.com/mrcaseb/nflfastR/actions) [![Discord -Chat](https://img.shields.io/discord/308323056592486420.svg)](https://discord.gg/5Er2FBnnQa) -[![Twitter -Follow](https://img.shields.io/twitter/follow/nflfastR.svg?style=social)](https://twitter.com/nflfastR) +Chat](https://img.shields.io/discord/308323056592486420.svg)](https://discord.com/invite/5Er2FBnnQa) + @@ -114,29 +113,21 @@ incorporating the pre-game spread. ## Special thanks -- To [Nick Shoemaker](https://twitter.com/WeightRoomShoe) for [finding - and making available JSON-formatted NFL play-by-play back to +- To Nick Shoemaker for [finding and making available JSON-formatted + NFL play-by-play back to 1999](https://github.com/CroppedClamp/nfl_pbps) (`nflfastR` uses this source for 1999 and 2000 and previously also used it for 2001-2010) -- To [Lau Sze Yui](https://twitter.com/903124S) for developing a - scraping function to access JSON-formatted NFL play-by-play - beginning in 2001. -- To [Lee Sharpe](https://twitter.com/LeeSharpeNFL) for curating a - resource for game information -- To [Timo Riske](https://twitter.com/PFF_Moo), [Lau Sze - Yui](https://twitter.com/903124S), [Sean - Clement](https://twitter.com/SeanfromSeabeck), and [Daniel - Houston](https://twitter.com/CowboysStats) for many helpful - discussions regarding the development of the new `nflfastR` models -- To [Zach Feldman](https://twitter.com/ZachFeldman3) and [Josh - Hermsmeyer](https://twitter.com/friscojosh) for many helpful - discussions about CPOE models as well as [Peter - Owen](https://twitter.com/JSmoovesBrekkie) for [many helpful - suggestions for the CP - model](https://twitter.com/JSmoovesBrekkie/status/1268885950626623490) -- To [Florian Schmitt](https://twitter.com/Flosch1006) for the logo - design +- To Lau Sze Yui for developing a scraping function to access + JSON-formatted NFL play-by-play beginning in 2001. +- To Lee Sharpe for curating a resource for game information +- To Timo Riske, Lau Sze Yui, Sean Clement, and Daniel Houston for + many helpful discussions regarding the development of the new + `nflfastR` models +- To Zach Feldman and Josh Hermsmeyer for many helpful discussions + about CPOE models as well as Peter Owen for many helpful suggestions + for the CP model +- To Florian Schmitt for the logo design - The many users who found and reported bugs in `nflfastR` 1.0 - And of course, the original [`nflscrapR`](https://github.com/maksimhorowitz/nflscrapR) team, From 29a275399915ef5ec67536267b1315826a30d247 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 18:36:21 +0100 Subject: [PATCH 2/7] ignore revdep --- .Rbuildignore | 1 + .gitignore | 1 + 2 files changed, 2 insertions(+) diff --git a/.Rbuildignore b/.Rbuildignore index 02cce294..7c75676b 100644 --- a/.Rbuildignore +++ b/.Rbuildignore @@ -21,3 +21,4 @@ ^CRAN-RELEASE$ ^man/figures/readme-cp-model-1\.png$ ^man/figures/readme-epa-model-1\.png$ +^revdep$ diff --git a/.gitignore b/.gitignore index e474e3b6..58553cc7 100644 --- a/.gitignore +++ b/.gitignore @@ -29,3 +29,4 @@ vignettes/*.pdf .DS_Store docs inst/doc +revdep From 949d733b4c8266264193ee6a28b262d5154a7c81 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 18:43:24 +0100 Subject: [PATCH 3/7] Update CRAN comments --- cran-comments.md | 58 ++++++++++++++++++++++++++++++------------------ 1 file changed, 36 insertions(+), 22 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 8f8ceeb7..080f715f 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -1,32 +1,46 @@ ## Release summary -This is a minor release that -* adds a variable to an included data frame and -* fixes some minor bugs. +This is a major release that +* deprecates function arguments +* adds a new exported function +* cleans the source +* removes models from sysdata +* add new exported data +* fixes bugs ## Test environments -* local R installation, R 4.0.2 -* Debian Linux, R-devel, clang, ISO-8859-15 locale -* Debian Linux, R-devel, GCC -* Debian Linux, R-devel, GCC, no long double -* Debian Linux, R-patched, GCC -* Debian Linux, R-release, GCC -* Fedora Linux, R-devel, clang, gfortran -* Fedora Linux, R-devel, GCC -* CentOS 6 with Redhat Developer Toolset, R from EPEL -* macOS 10.13.6 High Sierra, R-release, brew -* macOS 10.13.6 High Sierra, R-release, CRAN's setup -* Ubuntu Linux 16.04 LTS, R-devel, GCC -* Ubuntu Linux 16.04 LTS, R-release, GCC -* Ubuntu Linux 16.04 LTS, R-devel with rchk -* Windows Server 2008 R2 SP1, R-devel, 32/64 bit -* Windows Server 2008 R2 SP1, R-oldrel, 32/64 bit -* Windows Server 2008 R2 SP1, R-patched, 32/64 bit -* Windows Server 2008 R2 SP1, R-release, 32/64 bit -* Linux (Xenial) (on travis-ci), R Versions oldrel, release, devel +* local R installation, R 4.0.3 +* Debian Linux, R-devel, clang, ISO-8859-15 locale +* Debian Linux, R-devel, GCC +* Debian Linux, R-devel, GCC, no long double +* Debian Linux, R-patched, GCC +* Debian Linux, R-release, GCC +* Fedora Linux, R-devel, clang, gfortran +* Fedora Linux, R-devel, GCC +* CentOS 8, stock R from EPEL +* Debian Linux, R-devel, GCC ASAN/UBSAN +* macOS 10.13.6 High Sierra, R-release, brew +* macOS 10.13.6 High Sierra, R-release, CRAN's setup +* Oracle Solaris 10, x86, 32 bit, R-release +* Oracle Solaris 10, x86, 32 bit, R-release, Oracle Developer Studio 12.6 +* Ubuntu Linux 20.04.1 LTS, R-devel, GCC +* Ubuntu Linux 20.04.1 LTS, R-release, GCC +* Ubuntu Linux 20.04.1 LTS, R-devel with rchk +* Windows Server 2008 R2 SP1, R-devel, 32/64 bit +* Windows Server 2008 R2 SP1, R-oldrel, 32/64 bit +* Windows Server 2008 R2 SP1, R-patched, 32/64 bit +* Windows Server 2008 R2 SP1, R-release, 32/64 bit * win-builder (devel) ## R CMD check results 0 errors | 0 warnings | 0 notes + +## revdepcheck results + +We checked 0 reverse dependencies, comparing R CMD check results across +CRAN and dev versions of this package. + + * We saw 0 new problems + * We failed to check 0 packages From b396089eacfd329f3456b70c158b5659fe922d79 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 18:44:26 +0100 Subject: [PATCH 4/7] Increment version number --- DESCRIPTION | 2 +- NEWS.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/DESCRIPTION b/DESCRIPTION index b2ccbb87..8b8b5ba3 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: nflfastR Title: Functions to Efficiently Access NFL Play by Play Data -Version: 3.2.0.9015 +Version: 4.0.0 Authors@R: c(person(given = "Sebastian", family = "Carl", diff --git a/NEWS.md b/NEWS.md index 26d9a809..6781df2b 100644 --- a/NEWS.md +++ b/NEWS.md @@ -1,4 +1,4 @@ -# nflfastR (development version) +# nflfastR 4.0.0 ## Breaking changes From c12e5e413afd5a2743f964871d01f5b1a3a48c94 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 18:55:10 +0100 Subject: [PATCH 5/7] Update CRAN comments --- cran-comments.md | 3 +++ 1 file changed, 3 insertions(+) diff --git a/cran-comments.md b/cran-comments.md index 080f715f..109df96b 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -8,6 +8,9 @@ This is a major release that * add new exported data * fixes bugs +The latest internal test on CRAN were failing due to changes in the infrastructure +the package is depending on. We made sure this won't happen in the future. + ## Test environments * local R installation, R 4.0.3 From 6737373c3049da6fd840b2189eaf78a438345a95 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 18:56:49 +0100 Subject: [PATCH 6/7] Remove broken test environments due to missing dependencies --- cran-comments.md | 3 --- 1 file changed, 3 deletions(-) diff --git a/cran-comments.md b/cran-comments.md index 109df96b..2e3dbb0e 100644 --- a/cran-comments.md +++ b/cran-comments.md @@ -22,11 +22,8 @@ the package is depending on. We made sure this won't happen in the future. * Fedora Linux, R-devel, clang, gfortran * Fedora Linux, R-devel, GCC * CentOS 8, stock R from EPEL -* Debian Linux, R-devel, GCC ASAN/UBSAN * macOS 10.13.6 High Sierra, R-release, brew * macOS 10.13.6 High Sierra, R-release, CRAN's setup -* Oracle Solaris 10, x86, 32 bit, R-release -* Oracle Solaris 10, x86, 32 bit, R-release, Oracle Developer Studio 12.6 * Ubuntu Linux 20.04.1 LTS, R-devel, GCC * Ubuntu Linux 20.04.1 LTS, R-release, GCC * Ubuntu Linux 20.04.1 LTS, R-devel with rchk From 65a2bb4cedb4c73d596f62845c20fd93995388e2 Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Mon, 15 Feb 2021 19:03:36 +0100 Subject: [PATCH 7/7] Push CRAN release file --- CRAN-RELEASE | 2 ++ 1 file changed, 2 insertions(+) create mode 100644 CRAN-RELEASE diff --git a/CRAN-RELEASE b/CRAN-RELEASE new file mode 100644 index 00000000..2802f6ac --- /dev/null +++ b/CRAN-RELEASE @@ -0,0 +1,2 @@ +This package was submitted to CRAN on 2021-02-15. +Once it is accepted, delete this file and tag the release (commit 6737373).