From d4a288fb2999fcb89d30f6f54fddd86fc986f2ae Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Sat, 20 Mar 2021 12:46:07 +0100 Subject: [PATCH 1/3] Increment version number --- DESCRIPTION | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DESCRIPTION b/DESCRIPTION index e9c9c29d..013d3cad 100644 --- a/DESCRIPTION +++ b/DESCRIPTION @@ -1,7 +1,7 @@ Type: Package Package: nflfastR Title: Functions to Efficiently Access NFL Play by Play Data -Version: 4.0.0.9014 +Version: 4.0.0.9015 Authors@R: c(person(given = "Sebastian", family = "Carl", From 234d80934942aed6a8af0754031f1f1457638ffe Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Sat, 20 Mar 2021 13:00:01 +0100 Subject: [PATCH 2/3] first step --- R/helper_additional_functions.R | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/R/helper_additional_functions.R b/R/helper_additional_functions.R index 72a1b951..5ab60613 100644 --- a/R/helper_additional_functions.R +++ b/R/helper_additional_functions.R @@ -269,11 +269,11 @@ clean_pbp <- function(pbp, ...) { #these things are used in clean_pbp() above # look for First[period or space]Last[maybe - or ' in last][maybe more letters in last][maybe Jr. or II or IV] -big_parser <- "(?<=)[A-Z][A-z]*(\\.|\\s)+[A-Z][A-z]*\\'*\\-*[A-Z]*[a-z]*(\\s((Jr.)|(Sr.)|I{2,3})|(IV))?" +big_parser <- "(?<=)[A-Z][A-z]*+(\\.|\\s)+[A-Z][A-z]*+\\'*\\-*[A-Z]*+[a-z]*+(\\s((Jr.)|(Sr.)|I{2,3})|(IV))?" # maybe some spaces and letters, and then a rush direction unless they fumbled -rush_finder <- "(?=\\s*[a-z]*\\s*((FUMBLES) | (left end)|(left tackle)|(left guard)|(up the middle)|(right guard)|(right tackle)|(right end)))" +rush_finder <- "(?=\\s*[a-z]*+\\s*((FUMBLES) | (left end)|(left tackle)|(left guard)|(up the middle)|(right guard)|(right tackle)|(right end)))" # maybe some spaces and leters, and then pass / sack / scramble -pass_finder <- "(?=\\s*[a-z]*\\s*(( pass)|(sack)|(scramble)))" +pass_finder <- "(?=\\s*[a-z]*+\\s*(( pass)|(sack)|(scramble)))" # to or for, maybe a jersey number and a dash receiver_finder <- "(?<=((to)|(for))\\s[:digit:]{0,2}\\-{0,1})" # weird play finder From 4272d74938e403567c4c57b794c224756193752c Mon Sep 17 00:00:00 2001 From: mrcaseb Date: Sat, 20 Mar 2021 13:28:02 +0100 Subject: [PATCH 3/3] NEWS --- NEWS.md | 1 + 1 file changed, 1 insertion(+) diff --git a/NEWS.md b/NEWS.md index d6e56f01..4d68987d 100644 --- a/NEWS.md +++ b/NEWS.md @@ -27,6 +27,7 @@ * `fixed_drive` now increments properly on onside kick recoveries (#215) * `fixed_drive` no longer counts a muffed kickoff as a one-play drive on its own (#217) * `fixed_drive` now properly increments after a safety (#219) +* Heavy performance boost for the function `clean_pbp()` # nflfastR 4.0.0