Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Josh Jacobs runs missing from nflreadr (likely due to formatting / play parsing) #483

Closed
2 tasks done
parsnipz opened this issue Sep 8, 2024 · 2 comments · Fixed by #484
Closed
2 tasks done

Josh Jacobs runs missing from nflreadr (likely due to formatting / play parsing) #483

parsnipz opened this issue Sep 8, 2024 · 2 comments · Fixed by #484

Comments

@parsnipz
Copy link

parsnipz commented Sep 8, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

not sure

Describe the bug

Two Josh Jacobs runs missing from Packers/Eagles game (2024_01_GB_PHI), in second half. Both have similar characteristics.

Reprex

library(nflreadr)
nflreadr::clear_cache()
stats <- load_pbp(2024)
sheet_id <- "11Al6Z123vfW7o_7fTVC_sKvEqjXpDICxpHjSiVhN3xc"
range_write(stats, ss = sheet_id, sheet = "Stats", range = "A1")

Expected Behavior

Josh Jacobs totaling 16 carries for 84 yards

Instead, missing plays have him at 14 carries for 52 yards. I am guessing this is due to the text in the missing plays (they both show an injury update and have two double asterisks)

nflverse_sitrep

> nflverse_sitrep()
── System Info ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.2.2 (2022-10-31) • Running under: macOS Ventura 13.0
── Package Status ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
   package installed  cran      dev behind
1 nflreadr  1.4.1.02 1.4.1 1.4.1.02       
── Package Options ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• No options set for above packages
── Package Dependencies ────────────────────────────────────────────────────────────────────────────────────────────────────────────
• cachem     (1.0.8)    • glue      (1.6.2)  • rappdirs (0.3.3)  
• cli        (3.6.2)    • graphics  (4.2.2)  • rlang    (1.1.2)  
• curl       (5.2.0)    • grDevices (4.2.2)  • stats    (4.2.2)  
• data.table (1.14.10)  • memoise   (2.0.1)  • tools    (4.2.2)  
• fastmap    (1.1.1)    • methods   (4.2.2)  • utils    (4.2.2)  
── Not Installed ───────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• nflfastRnfl4thnflversenflseedRnflplotR

Screenshots

Missing plays:

(12:53) (Shotgun) J.Jacobs left tackle pushed ob at GB 45 for 32 yards (N.Dean). ** Injury Update: PHI-Q.Mitchell has returned to the game.

(1:52) J.Jacobs right end to PHI 25 for no gain (Z.Baun). ** Injury Update: PHI-C.Gardner-Johnson has returned to the game.

Additional context

No response

@mrcaseb mrcaseb transferred this issue from nflverse/nflreadr Sep 8, 2024
@mrcaseb
Copy link
Member

mrcaseb commented Sep 8, 2024

Gotta be more explicit to remove injury updates only if the description starts with the injury pattern

@mrcaseb
Copy link
Member

mrcaseb commented Sep 8, 2024

Thanks for catching this @parsnipz

@guga31bb guga31bb linked a pull request Sep 8, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants