Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Kickoffs short of the landing zone have NA for their penalty_type #485

Closed
2 tasks done
mlounsberry opened this issue Sep 17, 2024 · 0 comments · Fixed by #486
Closed
2 tasks done

[BUG] Kickoffs short of the landing zone have NA for their penalty_type #485

mlounsberry opened this issue Sep 17, 2024 · 0 comments · Fixed by #486

Comments

@mlounsberry
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

1.4.0

Describe the bug

Kickoffs that have landed short of the landing zone have a penalty_type of NA. It still correctly says there is a penalty on the play.

Ex:

game_id = 2024_02_LAC_CAR
play_id = 1978

Reprex

NA

Expected Behavior

penalty_type = "Kick Short of Landing Zone"

nflverse_sitrep

NA

Screenshots

No response

Additional context

No response
@mrcaseb mrcaseb linked a pull request Sep 17, 2024 that will close this issue
Add new penalty type from dynamic kickoff rules #486
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new penalty type from dynamic kickoff rules nflverse/nflfastR
1 participant
@mlounsberry