Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pfr_id to players dataset #193

Closed
alecglen opened this issue Aug 4, 2023 · 3 comments
Closed

Add pfr_id to players dataset #193

alecglen opened this issue Aug 4, 2023 · 3 comments

Comments

@alecglen
Copy link

alecglen commented Aug 4, 2023

  1. Is your feature request related to a problem? Please describe.

    Currently you have to join across e.g. rosters or ff_playerids to get from players to pfr_advstats via IDs.

  2. Describe the solution you'd like

    Add a pfr_id column to the dataset returned by load_players() to enable a direct join to PFR data.


Not a high priority, just a convenience ask if it's not too much effort.

@mrcaseb
Copy link
Member

mrcaseb commented Aug 7, 2023

PFR ID already is on the list of IDs we plan to add. Related issue nflverse/nflverse-rosters#72

I am going to close this as it is more or less a duplicate of the above mentioned issue.

@mrcaseb mrcaseb closed this as completed Aug 7, 2023
@alecglen
Copy link
Author

alecglen commented Aug 7, 2023

🤦 missed that, thanks @mrcaseb

@mrcaseb
Copy link
Member

mrcaseb commented Aug 7, 2023

No worries. It was in another repo so I don't expect you to find it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants