Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQ] Update headshot_url for 2024 Draft Class in NFL Roster database #44

Closed
1 task done
jmstew3 opened this issue Jun 15, 2024 · 1 comment
Closed
1 task done

Comments

@jmstew3
Copy link

jmstew3 commented Jun 15, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Is your feature request related to a problem? Please describe.

  1. Player profile headshot urls are missing for the 2024 NFL draft class in the NFL Rosters database. Would also be nice if those URLs were added to the Draft database.

Describe the solution you'd like

Add new player headshot image urls to the NFL Roster database for players who were taken in the 2024 NFL draft. Also, add a new table column for headshot url in the NFL Draft database.

Describe alternatives you've considered

I tried to access the base url for the player profile urls (https://static.www.nfl.com/image/private/f_auto,q_auto/league/...) to see if I could contribute, but I don't have access that server.

Additional context

No response

@john-b-edwards
Copy link
Collaborator

john-b-edwards commented Aug 5, 2024

These headshots are not available yet from the NFL. You can check this yourself--Caleb William's NFL.com page does not have a headshot. So unfortunately, we can't provide links to headshots that don't yet exist.

As this is an issue on the NFL's end, and not anything with our code, I'm going to close this issue. If the NFL adds these headshots, I'm confident that our code will ingest the new headshots appropriate, but in the event that it doesn't, feel free to re-open this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants