Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

load_players should have all IDs from load_roster and load_ff_playerids #7

Open
tanho63 opened this issue Aug 9, 2022 · 2 comments
Open

load_players should have all IDs from load_roster and load_ff_playerids #7

tanho63 opened this issue Aug 9, 2022 · 2 comments

Comments

@tanho63
Copy link
Member

tanho63 commented Aug 9, 2022

I believe we currently have it that IDs are joined onto load_rosters for backwards compat, but really our primary ID file should be load_players()

thoughts @john-b-edwards @mrcaseb ?
@john-b-edwards
Copy link
Collaborator

Did we decide on this or did we want to use nflreadr::load_ff_playerids() instead as the primary ID file?

@tanho63
Copy link
Member Author

tanho63 commented Aug 5, 2024

We should make load_players the core for nflverse and tack on ff_playerids afterwards imo. This more or less fell through the cracks unfortunately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@john-b-edwards @tanho63