Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Spotrac player IDs in roster.csv #29

Open
nickwan opened this issue Apr 23, 2022 · 6 comments
Open

Include Spotrac player IDs in roster.csv #29

nickwan opened this issue Apr 23, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@nickwan
Copy link

nickwan commented Apr 23, 2022

Hello, can yall please have Spotrac ID support available somewhere to join on? The spotrac ID looks unique to their site (i.e. Larry Fitzgerald's Spotrac ID is 966, while his NFL ID is 2506106, esb ID is FIT437493, gsis ID is 00-0022921, and college ID is 2927)

Alternatively, if you ingest salary info into a roster file that would also be cool. bonus points for draft day info

@tanho63 tanho63 transferred this issue from nflverse/nflfastR Apr 25, 2022
@tanho63 tanho63 added the enhancement New feature or request label Apr 25, 2022
@tanho63
Copy link
Member

tanho63 commented Apr 25, 2022

IDs shouldn’t be too tricky aside from the usual name join BS. Contract data definitely a bit more involved.

Is OTC better than spotrac to store?

@mrcaseb
Copy link
Member

mrcaseb commented Apr 25, 2022

I wrote a scraper that scrapes historical contract data from sites like this
https://overthecap.com/contract-history/quarterback/
image

Data will look like this:
image

I think the OTC IDs are not the same as spotrac IDs. Do you guys think this data is valuable in the nflverse @tanho63 and @nickwan? We could automate the scraper and add a function in nflreadr to load all historical contracts.

@tanho63
Copy link
Member

tanho63 commented Apr 25, 2022

100% useful!

@mrcaseb
Copy link
Member

mrcaseb commented Apr 25, 2022

scraping all positions results in ~31k contracts fwiw

@mrcaseb
Copy link
Member

mrcaseb commented Apr 25, 2022

I wrote a scraper that scrapes historical contract data from sites like this https://overthecap.com/contract-history/quarterback/ image

Data will look like this: image

I think the OTC IDs are not the same as spotrac IDs. Do you guys think this data is valuable in the nflverse @tanho63 and @nickwan? We could automate the scraper and add a function in nflreadr to load all historical contracts.

The current version of this data is now attached to this release https://github.com/nflverse/nflverse-data/releases/tag/otc_contract_data

@tanho63
Copy link
Member

tanho63 commented Apr 26, 2022

Update: after some discussion about naming it's now actually here lol https://github.com/nflverse/nflverse-data/releases/contracts

Still TODO: gsis/nflverse id -> otc id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants