Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pfr_id is still missing for rookies #74

Open
2 tasks done
christianlohr9 opened this issue Feb 1, 2023 · 0 comments
Open
2 tasks done

pfr_id is still missing for rookies #74

christianlohr9 opened this issue Feb 1, 2023 · 0 comments

Comments

@christianlohr9
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

  • I have installed the latest development version of the package.

What version of the package do you have?

4.5.1

Describe the bug

I want to join true positions from ESPN Fantasy (via ffscrapr) to the snap counts of players (like TJ Watt as a DE).
Unfortunately the pfr_id (and pff_id btw) is still missing from the roster file, so that I'd have to join via name (which sometimes works, sometimes works not).

Reprex

r
players_nflfastr <- nflfastR::fast_scraper_roster() |> dplyr::filter(rookie_year==2022)

Created on 2023-02-01 with reprex v2.0.2



### Expected Behavior

Get pfr_id for players 

### nflverse_sitrep

```r
> nflverse::nflverse_sitrep()
── System Info ──────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• R version 4.2.1 (2022-06-23 ucrt)   • Running under: Windows 10 x64 (build 22621)
── nflverse Packages ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• nflreadr (1.3.2)  • nflseedR (1.2.0)  • nflplotR (1.1.0)  
• nflfastR (4.5.1)  • nfl4th   (1.0.2)  • nflverse (1.0.2)  
── nflverse Options ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
No options set for nflreadr, nflfastR, nflseedR, nfl4th, nflplotR, and nflverse
── nflverse Dependencies ────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────
• askpass     (1.1)     • httr       (1.4.4)     • proto        (1.0.0)    
• cachem      (1.0.6)   • isoband    (0.2.7)     • purrr        (0.3.4)    
• cli         (3.4.1)   • janitor    (2.1.0)     • R6           (2.5.1)    
• codetools   (0.2-18)  • jsonlite   (1.8.0)     • rappdirs     (0.3.3)    
• colorspace  (2.0-3)   • labeling   (0.4.2)     • RColorBrewer (1.1-3)    
• cpp11       (0.4.3)   • lattice    (0.20-45)   • Rcpp         (1.0.9)    
• crayon      (1.5.2)   • lifecycle  (1.0.3)     • rlang        (1.0.6)    
• curl        (4.3.3)   • listenv    (0.8.0)     • rstudioapi   (0.14)     
• data.table  (1.14.2)  • lubridate  (1.8.0)     • scales       (1.2.1)    
• digest      (0.6.29)  • magick     (2.7.3)     • snakecase    (0.11.0)   
• dplyr       (1.0.9)   • magrittr   (2.0.3)     • stringi      (1.7.8)    
• fansi       (1.0.3)   • MASS       (7.3-58.1)  • stringr      (1.5.0)    
• farver      (2.1.1)   • Matrix     (1.5-3)     • sys          (3.4.1)    
• fastmap     (1.1.0)   • memoise    (2.0.1)     • tibble       (3.1.8)    
• fastrmodels (1.0.2)   • mgcv       (1.8-41)    • tidyr        (1.2.0)    
• furrr       (0.3.1)   • mime       (0.12)      • tidyselect   (1.2.0)    
• future      (1.29.0)  • munsell    (0.5.0)     • timechange   (0.1.1)    
• generics    (0.1.3)   • nlme       (3.1-159)   • utf8         (1.2.2)    
• ggplot2     (3.4.0)   • openssl    (2.0.5)     • vctrs        (0.5.1)    
• globals     (0.16.2)  • parallelly (1.32.1)    • viridisLite  (0.4.1)    
• glue        (1.6.2)   • pillar     (1.8.1)     • withr        (2.5.0)    
• gsubfn      (0.7)     • pkgconfig  (2.0.3)     • xgboost      (1.6.0.1)  
• gtable      (0.3.1)   • progressr  (0.11.0)      
─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────

Screenshots

No response

Additional context

No response

@mrcaseb mrcaseb transferred this issue from nflverse/nflfastR Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant