Tyler Conklin's PFR ID

[marvin3FF]

Is there an existing issue for this?

• I have searched the existing issues

Have you installed the latest development version of the package(s) in question?

• I have installed the latest development version of the package.

If this is a data issue, have you tried clearing your nflverse cache?

I have cleared my nflverse cache and the issue persists.

What version of the package do you have?

1.4.0.9

Describe the bug

When I run the load_rosters_weekly function on nflreadR, I noticed that Tyler Conklin's pfr_id is incorrect for 2023. In 2022, it's correctly listed as ConkTy00. In 2023, I believe it's pulling Ryan Izzo's ID of IzzoRy00. I'm not sure if this is affecting any other players - this is the only one I've noticed so far.

Reprex

Rosters <- load_rosters_weekly(2022:2023)%>%
  filter(gsis_id == "00-0034270")

Expected Behavior

I expected Tyler Conklin's pfr_id to be correctly listed in 2022 and 2023.

nflverse_sitrep

-- System Info ----------------------------------------------------------------------------------------------------------------------------------
* R version 4.1.2 (2021-11-01) * Running under: Windows 10 x64 (build 22621)
-- Package Status -------------------------------------------------------------------------------------------------------------------------------
   package  installed  cran        dev behind
1   nfl4th 1.0.4.9001 1.0.4 1.0.4.9001       
2 nflfastR 4.6.0.9000 4.6.0 4.6.0.9000       
3 nflplotR 1.2.0.9004 1.2.0 1.2.0.9004       
4 nflreadr   1.4.0.09 1.4.0   1.4.0.11    dev
5 nflseedR      1.2.0 1.2.0      1.2.0       
6 nflverse      1.0.3 1.0.3      1.0.3       
-- Package Options ------------------------------------------------------------------------------------------------------------------------------
* No options set for above packages
-- Package Dependencies -------------------------------------------------------------------------------------------------------------------------
* askpass     (1.1)     * janitor      (2.1.0)   * stringr     (1.4.1)    
* backports   (1.4.1)   * jsonlite     (1.8.0)   * sys         (3.4)      
* cachem      (1.0.6)   * labeling     (0.4.2)   * tibble      (3.1.8)    
* cli         (3.3.0)   * lifecycle    (1.0.1)   * tidyr       (1.2.0)    
* colorspace  (2.0-3)   * listenv      (0.8.0)   * tidyselect  (1.1.2)    
* cpp11       (0.4.2)   * lubridate    (1.8.0)   * utf8        (1.2.2)    
* crayon      (1.5.1)   * magick       (2.7.3)   * vctrs       (0.4.1)    
* curl        (4.3.2)   * magrittr     (2.0.3)   * viridisLite (0.4.1)    
* data.table  (1.14.2)  * memoise      (2.0.1)   * withr       (2.5.0)    
* digest      (0.6.29)  * mime         (0.12)    * xgboost     (1.6.0.1)  
* dplyr       (1.0.10)  * munsell      (0.5.0)   * codetools   (0.2-18)   
* ellipsis    (0.3.2)   * openssl      (2.0.2)   * compiler    (4.1.2)    
* fansi       (1.0.3)   * parallelly   (1.32.1)  * graphics    (4.1.2)    
* farver      (2.1.1)   * pillar       (1.8.1)   * grDevices   (4.1.2)    
* fastmap     (1.1.0)   * pkgconfig    (2.0.3)   * grid        (4.1.2)    
* fastrmodels (1.0.2)   * progressr    (0.11.0)  * lattice     (0.20-45)  
* furrr       (0.3.1)   * proto        (1.0.0)   * MASS        (7.3-54)   
* future      (1.28.0)  * purrr        (0.3.4)   * Matrix      (1.3-4)    
* generics    (0.1.3)   * R6           (2.5.1)   * methods     (4.1.2)    
* ggpath      (1.0.1)   * rappdirs     (0.3.3)   * mgcv        (1.8-38)   
* ggplot2     (3.3.6)   * RColorBrewer (1.1-3)   * nlme        (3.1-153)  
* globals     (0.16.1)  * Rcpp         (1.0.9)   * parallel    (4.1.2)    
* glue        (1.6.2)   * rlang        (1.0.5)   * splines     (4.1.2)    
* gsubfn      (0.7)     * rstudioapi   (0.14)    * stats       (4.1.2)    
* gtable      (0.3.1)   * scales       (1.2.1)   * tools       (4.1.2)    
* httr        (1.4.4)   * snakecase    (0.11.0)  * utils       (4.1.2)    
* isoband     (0.2.5)   * stringi      (1.7.8)     
-------------------------------------------------

Screenshots

No response

Additional context

No response

[john-b-edwards]

@tanho63 looks like this is coming from nflreadr::load_ff_playerids():

nflreadr::load_ff_playerids() |>
    dplyr::filter(gsis_id == "00-0034270") |>
    data.frame()
#>   mfl_id                        sportradar_id fantasypros_id    gsis_id pff_id
#> 1  13847 40b8fa44-b289-42dd-9606-a1ae30adc7bc          17541 00-0034270  47327
#>   sleeper_id nfl_id espn_id yahoo_id fleaflicker_id  cbs_id   pfr_id
#> 1       5094   <NA> 3915486    31127           <NA> 2138988 IzzoRy00
#>     cfbref_id rotowire_id rotoworld_id ktc_id stats_id stats_global_id
#> 1 ryan-izzo-1       12529        13349   <NA>    31220          834990
#>   fantasy_data_id swish_id      name merge_name position team  birthdate  age
#> 1           20069   834990 Ryan Izzo  ryan izzo       TE   FA 1995-12-21 27.2
#>   draft_year draft_round draft_pick draft_ovr twitter_username height weight
#> 1       2018           7         32       250             <NA>     77    255
#>         college db_season
#> 1 Florida State      2024

How would you like to handle this?

[tanho63]

so Izzo should have 00-0034439 and Conklin should have 00-0034270? added an entry here and reran the player id pipeline so ff_playerids should be fixed shortly (I think we should maintain something similar on the nflverse side actually, and bully people into making PRs for it)