Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate pin origins #536

Closed
alanshaw opened this issue Oct 6, 2021 · 0 comments · May be fixed by #2016
Closed

Validate pin origins #536

alanshaw opened this issue Oct 6, 2021 · 0 comments · May be fixed by #2016
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up pi/support-0 pi/upload-v2 stack/api-protocols

Comments

@alanshaw
Copy link
Contributor

alanshaw commented Oct 6, 2021

When adding/replacing pins with the pinning service API...

We currently put these in the DB without validating the data is an array of mutliaddr.

Note: should be array of strings max 20 as per https://ipfs.github.io/pinning-services-api-spec/#tag/pins/paths/~1pins/post
@alanshaw alanshaw added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization labels Oct 6, 2021
@dchoi27 dchoi27 added P2 Medium: Good to have, but can wait until someone steps up and removed need/triage Needs initial labeling and prioritization labels Oct 8, 2021
redaphid added a commit that referenced this issue Jun 21, 2022
@redaphid
feat: Validate pin origins
a0bf9ec 
Closes #536
@redaphid redaphid mentioned this issue Jun 21, 2022
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up pi/support-0 pi/upload-v2 stack/api-protocols
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Validate pin origins nftstorage/nft.storage
4 participants
@alanshaw @redaphid @dchoi27 @elizabeth-griffiths