code reviews

Author: salonichf5

internal/controller/state/graph/gateway.go

@@ -213,8 +213,7 @@ func validateGateway(
 			conds = append(conds, conditions.NewGatewayUnsupportedValue(valErr.Error())...)
 		} else {
 			secretNsName, secretNs := getGatewayCertSecretNsName(gw)
-			err := secretResolver.resolve(*secretNsName)
-			if err != nil {
+			if err := secretResolver.resolve(*secretNsName); err != nil {
 				path := field.NewPath("backend.clientCertificateRef")
 				valErr := field.Invalid(path, secretNsName, err.Error())
 				conds = append(conds, conditions.NewGatewaySecretRefInvalid(valErr.Error()))

internal/controller/state/graph/multiple_gateways_test.go

@@ -65,6 +65,8 @@ var (
 			{Kind: kinds.TLSRoute, Group: helpers.GetPointer[gatewayv1.Group](gatewayv1.GroupName)},
 		},
 	}
+
+	experimentalFeaturesEnabled = false
 )
 
 func createGateway(name, namespace, nginxProxyName string, listeners []gatewayv1.Listener) *gatewayv1.Gateway {
@@ -400,7 +402,7 @@ func Test_MultipleGateways_WithNginxProxy(t *testing.T) {
 					PolicyValidator:     fakePolicyValidator,
 				},
 				logr.Discard(),
-				false,
+				experimentalFeaturesEnabled,
 			)
 
 			g.Expect(helpers.Diff(test.expGraph, result)).To(BeEmpty())
@@ -890,7 +892,7 @@ func Test_MultipleGateways_WithListeners(t *testing.T) {
 					PolicyValidator:     fakePolicyValidator,
 				},
 				logr.Discard(),
-				false,
+				experimentalFeaturesEnabled,
 			)
 
 			g.Expect(helpers.Diff(test.expGraph, result)).To(BeEmpty())