-
Notifications
You must be signed in to change notification settings - Fork 142
Add SupportedFeatures to GatewayClassStatus #4236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4236 +/- ##
==========================================
- Coverage 86.17% 86.16% -0.01%
==========================================
Files 131 132 +1
Lines 14217 14273 +56
Branches 35 35
==========================================
+ Hits 12252 12299 +47
- Misses 1763 1769 +6
- Partials 202 205 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shaun-nx
approved these changes
Nov 7, 2025
sjberman
reviewed
Nov 10, 2025
bc86ffd to
3da168e
Compare
sjberman
reviewed
Nov 11, 2025
sjberman
approved these changes
Nov 11, 2025
7a1064a to
ed6a80a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As part of Gateway API release 1.4, the field supportedFeatures in GatewayClass spec is being moved to standard. We don't currently support this.
Solution: Add SupportedFeatures to GatewayClassStatus
Testing: Output of describe on GatewayClass (with experimental enabled - TLSRoute is not present in the list otherwise) :
Confirmed that the same conformance tests run as when we had the
supported-featuresflag configuredPlease focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.
Closes #3943
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.