Skip to content

Conversation

@ciarams87
Copy link
Contributor

@ciarams87 ciarams87 commented Nov 7, 2025

Proposed changes

Problem: As part of Gateway API release 1.4, the field supportedFeatures in GatewayClass spec is being moved to standard. We don't currently support this.

Solution: Add SupportedFeatures to GatewayClassStatus

Testing: Output of describe on GatewayClass (with experimental enabled - TLSRoute is not present in the list otherwise) :

k describe gatewayclasses.gateway.networking.k8s.io nginx
Name:         nginx
<....>
  Supported Features:
    Name:  BackendTLSPolicy
    Name:  GRPCRoute
    Name:  Gateway
    Name:  GatewayAddressEmpty
    Name:  GatewayHTTPListenerIsolation
    Name:  GatewayInfrastructurePropagation
    Name:  GatewayPort8080
    Name:  GatewayStaticAddresses
    Name:  HTTPRoute
    Name:  HTTPRouteBackendProtocolWebSocket
    Name:  HTTPRouteDestinationPortMatching
    Name:  HTTPRouteHostRewrite
    Name:  HTTPRouteMethodMatching
    Name:  HTTPRouteParentRefPort
    Name:  HTTPRoutePathRedirect
    Name:  HTTPRoutePathRewrite
    Name:  HTTPRoutePortRedirect
    Name:  HTTPRouteQueryParamMatching
    Name:  HTTPRouteRequestMirror
    Name:  HTTPRouteRequestMultipleMirrors
    Name:  HTTPRouteRequestPercentageMirror
    Name:  HTTPRouteResponseHeaderModification
    Name:  HTTPRouteSchemeRedirect
    Name:  ReferenceGrant
    Name:  TLSRoute
Events:    <none>

Confirmed that the same conformance tests run as when we had the supported-features flag configured

Please focus on (optional): If you any specific areas where you would like reviewers to focus their attention or provide
specific feedback, add them here.

Closes #3943

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.

Add SupportedFeatures to GatewayClassStatus

@ciarams87 ciarams87 requested a review from a team as a code owner November 7, 2025 09:53
@github-actions github-actions bot added enhancement New feature or request tests Pull requests that update tests labels Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (aa0f45c) to head (ed6a80a).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4236      +/-   ##
==========================================
- Coverage   86.17%   86.16%   -0.01%     
==========================================
  Files         131      132       +1     
  Lines       14217    14273      +56     
  Branches       35       35              
==========================================
+ Hits        12252    12299      +47     
- Misses       1763     1769       +6     
- Partials      202      205       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ciarams87 ciarams87 force-pushed the feat/supported-features-gwc-status branch 2 times, most recently from bc86ffd to 3da168e Compare November 11, 2025 12:37
@ciarams87 ciarams87 force-pushed the feat/supported-features-gwc-status branch from 7a1064a to ed6a80a Compare November 12, 2025 09:08
@ciarams87 ciarams87 merged commit 0212980 into main Nov 12, 2025
97 of 102 checks passed
@ciarams87 ciarams87 deleted the feat/supported-features-gwc-status branch November 12, 2025 12:25
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in NGINX Gateway Fabric Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request release-notes tests Pull requests that update tests

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Move supportedFeatures field in GatewayClass spec to standard

4 participants