Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10-listen-on-ipv6-by-default.sh should cover templates that supported by 20-envsubst-on-templates.sh #947

Open
markxp opened this issue Dec 4, 2024 · 1 comment

Comments

@markxp
Copy link

markxp commented Dec 4, 2024

Is your feature request related to a problem? Please describe

Although 20-envsubst-on-templates.sh support environment varibable substitution, I still want the incompleted server config be supported by 10-listen-on-ipv6-by-default.sh.

Describe the solution you'd like

Currently, 10-listen-on-ipv6-by-default.sh only parse DEFAULT_CONF_FILE, defined in line 13.
The value of DEFAULT_CONF_FILE="etc/nginx/conf.d/default.conf"
I suggest to support "etc/nginx/templates/default.conf.template" or enable a enironment variable read at line 13.

Such as
DEFAULT_CONF_FILE= "${NGINX_DEFAULT_CONF:-etc/nginx/templates/default.conf.template}"

@thresheek
Copy link
Collaborator

Hi @markxp!

What's the point to use the srcipt to change the template you're already providing manually, and, thus, are able to change the way you want?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants