-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test/add runtime manager tests #2175
Test/add runtime manager tests #2175
Conversation
218715f
to
ec0048d
Compare
da784fc
to
e0d5d1c
Compare
e0d5d1c
to
7f6d1bf
Compare
fe8d2fc
to
547e903
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2175 +/- ##
==========================================
+ Coverage 88.79% 89.21% +0.42%
==========================================
Files 100 100
Lines 7531 7539 +8
Branches 50 50
==========================================
+ Hits 6687 6726 +39
+ Misses 788 756 -32
- Partials 56 57 +1 ☔ View full report in Codecov by Sentry. |
1318e1b
to
2626ca2
Compare
2626ca2
to
8b94a05
Compare
latest updates are in this commit: 8b94a05 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miledxz there are a couple of issues in the pipeline. See my other comment for details: #2175 (comment)
@kate-osborn added lint fix update, take a look when u have time |
7154d57
to
1a56441
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Hi @miledxz! Welcome to the project! 🎉 Thanks for opening this pull request! |
Proposed changes
Reopening pr trough another pr because issues on github
update on this: #1555, since I did mistake and discarded all commits,
I haven't find better solution so I opened another pr @sjberman @kate-osborn
Closes #1498
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.