Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data/control plane split design #2729

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

sjberman
Copy link
Contributor

@sjberman sjberman commented Oct 28, 2024

With the upcoming agent v3 release, the design for our control plane and data plane separation needs an update. Much of this is based off of discoveries from a recent PoC, as well as predicted design and implementation details that may be necessary. Added a new proposal that supersedes the old design.

Closes #2655

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 28, 2024
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
design/control-data-plane-separation/design.md Outdated Show resolved Hide resolved
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.86%. Comparing base (5b38d8c) to head (5e8b715).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2729   +/-   ##
=======================================
  Coverage   89.86%   89.86%           
=======================================
  Files         107      107           
  Lines       10997    10997           
  Branches       50       50           
=======================================
  Hits         9883     9883           
  Misses       1054     1054           
  Partials       60       60           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjberman sjberman force-pushed the design/cp-dp-split branch 3 times, most recently from 039e08a to 245f57f Compare November 25, 2024 15:59
@sjberman sjberman marked this pull request as ready for review November 25, 2024 16:11
@sjberman sjberman requested review from a team as code owners November 25, 2024 16:11
With the upcoming agent v3 release, the design for our control plane and data plane separation needs an update. Much of this is based off of discoveries from a recent PoC, as well as predicted design and implementation details that may be necessary. Added a new proposal that supersedes the old design.
Copy link
Contributor

@salonichf5 salonichf5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@sjberman sjberman enabled auto-merge (squash) November 27, 2024 04:12
@sjberman sjberman merged commit f56f525 into nginxinc:main Nov 27, 2024
40 checks passed
@sjberman sjberman deleted the design/cp-dp-split branch November 27, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Design for Data and Control Plane Separation
5 participants