-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Update documentation action, bump version for local testing #2820
Merged
ADubhlaoich
merged 3 commits into
nginxinc:main
from
ADubhlaoich:docs/update-theme-tooling
Nov 26, 2024
Merged
feat: Update documentation action, bump version for local testing #2820
ADubhlaoich
merged 3 commits into
nginxinc:main
from
ADubhlaoich:docs/update-theme-tooling
Nov 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
documentation
Improvements or additions to documentation
label
Nov 26, 2024
This commit bumps the theme version for the documentation website, and updates the GitHub action used for deploying the website. The update allows you to specify what version of the theme to use for a deployment, which reduces the drift compared to relying on the local version.
ADubhlaoich
force-pushed
the
docs/update-theme-tooling
branch
from
November 26, 2024 16:43
99e9d08
to
c655bdb
Compare
sjberman
reviewed
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2820 +/- ##
==========================================
- Coverage 89.86% 89.75% -0.12%
==========================================
Files 107 106 -1
Lines 10997 10768 -229
Branches 50 0 -50
==========================================
- Hits 9883 9665 -218
+ Misses 1054 1043 -11
Partials 60 60 ☔ View full report in Codecov by Sentry. |
bjee19
reviewed
Nov 26, 2024
Co-authored-by: bjee19 <[email protected]>
sjberman
approved these changes
Nov 26, 2024
bjee19
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks alan!
ADubhlaoich
added a commit
to ADubhlaoich/ngf-doc-work
that referenced
this pull request
Nov 27, 2024
…inxinc#2820) This commit bumps the theme version for the documentation website, and updates the GitHub action used for deploying the website. The update allows you to specify what version of the theme to use for a deployment, which reduces the drift compared to relying on the local version. Co-authored-by: bjee19 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This commit bumps the theme version for the documentation website, and updates the GitHub action used for deploying the website. The update allows you to specify what version of the theme to use for a deployment, which reduces the drift compared to relying on the local version.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.