Fix: SnippetsFilter CRD missing from crd.yaml #2821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will need to be cherry-picked to the release branch |
salonichf5
approved these changes
Nov 26, 2024
sjberman
approved these changes
Nov 26, 2024
kate-osborn
added a commit
that referenced
this pull request
Nov 26, 2024
Problem: The SnippetsFilter CRD is missing from deploy/crds.yaml, which is used to install NGF with manifests. Solution: Add SnippetsFilter CRD to the kustomization file that is used to generate the deploy/crds.yaml file.
kate-osborn
added a commit
that referenced
this pull request
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: The SnippetsFilter CRD is missing from the deploy/crd.yaml file.
Solution: Add the SnippetsFilter CRD to the kustomize file that is used to generate deploy/crd.yaml.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes
If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.