Replies: 1 comment
-
I have confirmed that this change is compatible with DigitalOcean's Object Spaces |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Note
We are still interested in understanding the impact of this change, but have decided to temporarily introduce the
S3_STYLE
configuration optionvirtual-v2
that enables the below-described functionality. Please use this option to test your compatibility and let us know here if it works for you. The default behaviour will remain unchanged.Hi All, we are about to ship a feature to support the S3 Express One Zone buckets and I was able to simplify how the s3 hostname for is calculated for
S3_STYLE=virtual
configurations (which is the default). This normalizes:Host
headerhost
element of the V4 signature canonical headersThe primary change is that we are moving from this:
server ${S3_SERVER}:${S3_SERVER_PORT};
to this:
server ${S3_BUCKET_NAME}.${S3_SERVER}:${S3_SERVER_PORT};
when forwarding the request to S3. .According to the latest documentation, this is the preferred way of making requests for "virtual" path style endpoints which every bucket in S3 should support. https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html
Here is the pull request. I will wait for a few days to see if are any concerns here before merging.
#229
0 votes ·
Beta Was this translation helpful? Give feedback.
All reactions