Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide performance benchmarks #16

Open
ngirard opened this issue May 16, 2020 · 3 comments
Open

Provide performance benchmarks #16

ngirard opened this issue May 16, 2020 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ngirard
Copy link
Owner

ngirard commented May 16, 2020

  • What to benchmark: indexing time / querying time
  • Comparison with mlocale / updatedb would be nice
  • Should be performed against a standardized directory structure. I quick search did not help with finding some reusable prior art.
  • Should be integrated with Github Actions.
@ngirard ngirard added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels May 16, 2020
@dufferzafar
Copy link

Hi, you do seem to be making some perf related commits. Like LZ4 etc. How are you measuring perf right now? Hyperfine on some directory?

@ngirard
Copy link
Owner Author

ngirard commented May 19, 2020

Hey @dufferzafar,

yes, I'm personally using hyperfine on a test configuration which indexes a few directories belonging to the same filesystem in my machine.

And there's an ongoing discussion on Reddit with a redditter willing to run his own benchmarks.

Like I said on Reddit, I changed the code for database updating so that it uses multiple threads. I noticed that there's an important overhead with my multithreaded implementation, so I'm suspecting there might be room for improvements. It would be nice if someone could take a look at it (9ec023f)

@dufferzafar
Copy link

dufferzafar commented May 19, 2020

Sorry, I wish I could help you, but I can't rust (or C++ for that matter.) I just let grown ups do the real work while I sit here and play with Python / bash.

But I would guess we could look at fd for this? It does multi-threaded file path search as well right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants