Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dialog version 5.0.0 not working with latest typescript version (5.4.5) #119

Open
mrs-cp opened this issue Apr 12, 2024 · 1 comment
Open

Comments

@mrs-cp
Copy link

mrs-cp commented Apr 12, 2024

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

We are getting compile errors for the ngneat/dialog when trying to update to the latest typescript (5.4.5) version:

Bildschirmfoto 2024-04-12 um 10 31 47

Expected behavior

dialog working as perfectly as with typescript 5.3.x

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

To avoid security warnings, we need to update our projects and their dependencies regularly. Since we love using the ngneat/dialog, it would be awesome to get a fix for this issue.

Environment


Angular version: 17.3.4

Browser:
- [x] Chrome (desktop) version 123.0.6312.107 
- [ ] Chrome (Android) version XX
- [ ] Chrome (iOS) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] Safari (iOS) version XX
- [ ] IE version XX
- [ ] Edge version XX
 
For Tooling issues:
- Node version: v20.9.0
- Platform:  Mac

Others:

@GitHubish
Copy link

Same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants