Example of updateRequestStatus to handle HttpClient errors

[ogix]

Hello, can you please provide an example of updateRequestStatus that shows how to handle errors of api calls using HttpClient in Angular? Thanks!

[NetanelBasal]

import { setRequestStatus } from '@ngneat/elf-requests';

this.http.get('').pipe(
 tap((todos) => setTodos(todos)),
 setRequestStatus(todosStore, 'todos')
)

The above code will do everything for you.

[ogix]

Got it, thanks! I just noticed that this pattern makes 2 operations - the first sets todos in the store and the second updates status. In conjunction with Data Source, the combined value is emitted 2 times and it triggers rendering twice. Is there a way to fix it?

BTW Also I noticed that it emits second value (probably when setting loading=true which is already true by default) exactly the same as the first one:

[NetanelBasal]

Can you please share the code?

[NetanelBasal]

Now I see why. There are two reasons why the setRequestStatus operator shouldn't handle the success update in this case:

1. As you experienced, it will produce two emissions.
2. Consumers should have the flexibility to define what a "successful" response is.

I'll remove it from the operator, and you will handle it in setTodos in our example:

setTodos() {
  store.update(
    addEntities(todos),
    updateRequestStatus('todos', 'success'),
  )
}

Does that sound good?

Regarding the second issue, I'll add protection.

[NetanelBasal]

The changes have been made to the latest version, and the documentation has been updated. Please let me know if it works for you.

[ogix]

Glad that you found the issue and were able to fix it! I've updated the package to the latest version and it works fine now. Thanks!