-
-
Notifications
You must be signed in to change notification settings - Fork 121
feat: 🔥 First punt at priority option #223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
theryansmee
wants to merge
45
commits into
main
Choose a base branch
from
feat/220-unique-values
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
6160c3c
feat: 🔥 First punt at priority option
485782e
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
theryansmee 6b57aa0
feat: 🔥 Clean up fakFromArray logic
theryansmee 713c77d
feat: 🔥 Replace use of random index logic with getRandomInRange
theryansmee bbe7b0b
feat: 🔥 Revert rand element logic for now
theryansmee 7f69bad
feat: 🔥 Allow devs to pass in comparison functions
theryansmee 77831a5
feat: 🔥 Add custom comparison functions non-conforming function
theryansmee 96acb7e
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
theryansmee af09284
feat: 🔥 Add json check unique function. Clean up code
theryansmee 6833592
feat: 🔥 Add generic comparison function
13998f6
feat: 🔥 Replace duplicate checkUnique logic with objectIsUnique
717bb7d
feat: 🔥 Fix function name. Update file name
660f53a
test: 🥳 Move error to snapshot
b18c227
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
42a54d4
feat: 🔥 Fix snapshot
0ec65be
feat: 🔥 Move snapshots folder to tests/ route
ff6980a
feat: 🔥 Clean up core file
d57bd25
feat: 🔥 Add missing priority doc comment
fc5f8fc
test: 🥳 Replace flakey regex
67c4f5f
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
2b84b1a
feat: 🔥 return empty array if length is 0
d4d1fa3
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
32b84de
feat: 🔥 clean up unique validators
6f7dcc6
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
2d0aecc
feat: 🔥 Add tests for unique validators
dbddca3
feat: 🔥 Fix reversed logic and corresponding tests
2331772
feat: 🔥 Combine uniqueComparer and comparisonKeys into config
b54d6b2
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
39e7fa5
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
e29cc7f
feat: 🔥 Simplify priority documentation comment
641a875
feat: 🔥 Tweak documentation comment to be priority specific
c48790a
feat: 🔥 Revert package.lock
f29cca6
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
e7dac07
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
77edc54
feat: 🔥 Fix merge conflicts in core
fee5cf6
Merge remote-tracking branch 'origin/main' into feat/220-unique-values
23f628e
fix: 🐞 Fix outdated tests
e2fb265
refactor: 💡 Remove commented out code
086ec7b
test: 🥳 Add basic tests for core fake function
2e5b650
refactor: 💡 Code review changes
10cd7d0
refactor: 💡 Code review changes
274fdc9
refactor: 💡 Change request changes
1143091
refactor: 💡 Code review changes
2a037d0
Update packages/falso/src/lib/core/core.ts
theryansmee 8869b35
refactor: 💡 Code review changes
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.