Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pause hotkey handling #62

Open
timnyborg opened this issue Aug 4, 2022 · 2 comments
Open

Pause hotkey handling #62

timnyborg opened this issue Aug 4, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@timnyborg
Copy link

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Performance issue
[X] Feature request
[ ] Documentation issue or request
[ ] Support request
[ ] Other... Please describe:

Current behavior

It is impossible (?) to temporarily disable the handling of hotkeys.

Expected behavior

Run hotkeysService.pause() to temporarily interrupt the handling of hotkeys, and .unpause() to resume handling.

What is the motivation / use case for changing the behavior?

When I display modals in my application, I want to prevent any hotkeys until they are dismissed.
It's a simple change, so I'm happy to put together a PR if the functionality would be welcome.

@NetanelBasal
Copy link
Member

You're welcome to submit a PR

@NetanelBasal NetanelBasal added the enhancement New feature or request label Aug 5, 2022
@Tweniee
Copy link

Tweniee commented Nov 7, 2023

@NetanelBasal is this feature implemented or open? attempt/#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants