fix(release): bump all dependencies to latest #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Did you did it using the ng update command? |
I did not the first time, but I went back to the previous commit and updated/migrated with ng update, it only changed the browserTarget to buildTarget in angular.json, I then updated other dependencies again, checking if there was breaking changes. All tests seem to pass. |
|
We also need to:
|
Sure, I'll try and do it this week. |
convert to standalone remove the module run the control flow migration convert the playground to standalone app
NetanelBasal
reviewed
Mar 8, 2024
NetanelBasal
reviewed
Mar 8, 2024
Changed effects to ngOnChanges for input changes in the directive. Used Omit<> to reuse Options type from the service instead of creating a new one. Removed unnecessary insert of the service into providers array.
|
5323d0c I also bumped the version number from 2.0.0 to 3.0.0 |
Put back ngOnDestroy
|
Hello, is there something else you would like me to change ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Dependencies are quite old
Issue Number: N/A
What is the new behavior?
Dependencies are up-to-date.
Does this PR introduce a breaking change?
I don't know
Other information