Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds angular 18 support #181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: adds angular 18 support #181

wants to merge 1 commit into from
+9,937 −6,699

Conversation

pavankjadda
Copy link
Contributor

@pavankjadda pavankjadda commented May 30, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[] No

Other information

Closes #179

@stackblitz StackBlitz
Copy link

stackblitz bot commented May 30, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@pavankjadda
Copy link
Contributor Author

Blocked by jscutlery/semver#814

@rbalet
Copy link

rbalet commented Jun 17, 2024

@pavankjadda Hi,

It seems they've fixed the error.
Can you try it out ?

bikecoders/ngx-deploy-npm#606

@pavankjadda
Copy link
Contributor Author

pavankjadda commented Jun 17, 2024 •
edited
Loading

@pavankjadda Hi,

It seems they've fixed the error. Can you try it out ?

bikecoders/ngx-deploy-npm#606

This jscutlery/semver#814 blocks the PR not bikecoders/ngx-deploy-npm#606

@dianjuar
Copy link

@rbalet, that was not a fix; was a workaround.

More info about the workaround:
jscutlery/semver#814 (comment)

Here, you can find an implementation of that workaround
https://github.com/bikecoders/ngx-deploy-npm/pull/606/files#r1634121869

@driatvak
Copy link

driatvak commented Jul 1, 2024

Hi @pavankjadda ,
Any updates on when support to angular v18 will be out ? 🙏

@pavankjadda
Copy link
Contributor Author

@NetanelBasal please merge this whenever you get a chance.

@NetanelBasal
Copy link
Member

The commit should be marked a BREAKING CHANGE based on the convention

@pavankjadda pavankjadda changed the title feat: adds angular 18 support BREAKING CHANGE: adds angular 18 support Jul 2, 2024
@pavankjadda pavankjadda changed the title BREAKING CHANGE: adds angular 18 support feat: adds angular 18 support Jul 2, 2024
@pavankjadda
feat: adds angular 18 support
ebe78bf 
BREAKING CHANGE: Bumps required angular version to 18
@pavankjadda
Copy link
Contributor Author

The commit should be marked a BREAKING CHANGE based on the convention

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support: angular v18
5 participants
@pavankjadda @rbalet @dianjuar @driatvak @NetanelBasal