Skip to content

Commit ee09828

Browse files
HIP: fix GPU_TARGETS (ggml-org#16642)
1 parent e56abd2 commit ee09828

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

ci/run.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ if [ ! -z ${GG_BUILD_ROCM} ]; then
7575
exit 1
7676
fi
7777

78-
CMAKE_EXTRA="${CMAKE_EXTRA} -DAMDGPU_TARGETS=${GG_BUILD_AMDGPU_TARGETS}"
78+
CMAKE_EXTRA="${CMAKE_EXTRA} -DGPU_TARGETS=${GG_BUILD_AMDGPU_TARGETS}"
7979
fi
8080

8181
if [ ! -z ${GG_BUILD_SYCL} ]; then

ggml/src/ggml-hip/CMakeLists.txt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,10 @@ if (CXX_IS_HIPCC)
2828
" Prefer setting the HIP compiler directly. See README for details.")
2929
endif()
3030
else()
31-
# Forward AMDGPU_TARGETS to CMAKE_HIP_ARCHITECTURES.
32-
if (AMDGPU_TARGETS AND NOT CMAKE_HIP_ARCHITECTURES)
31+
# Forward (AMD)GPU_TARGETS to CMAKE_HIP_ARCHITECTURES.
32+
if(GPU_TARGETS AND NOT CMAKE_HIP_ARCHITECTURES)
33+
set(CMAKE_HIP_ARCHITECTURES ${GPU_TARGETS})
34+
elseif(AMDGPU_TARGETS AND NOT CMAKE_HIP_ARCHITECTURES)
3335
set(CMAKE_HIP_ARCHITECTURES ${AMDGPU_TARGETS})
3436
endif()
3537
cmake_minimum_required(VERSION 3.21)

0 commit comments

Comments
 (0)