build: modernize build process

.changelogrc.js

@@ -1,3 +1,4 @@
+'use strict';
 // ? See https://github.com/conventional-changelog/conventional-changelog
 
 const debug = require('debug')(

.eslintrc.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const debug = require('debug')(`${require('./package.json').name}:eslint-config`);
 const restrictedGlobals = require('confusing-browser-globals');
 

babel.config.js

@@ -1,3 +1,4 @@
+'use strict';
 // * Every now and then, we adopt best practices from CRA
 // * https://tinyurl.com/yakv4ggx
 

commitlint.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   extends: ['@commitlint/config-conventional'],
   rules: {

expect-env.js

@@ -1,3 +1,4 @@
+'use strict';
 /* eslint-disable no-console */
 
 const debug = require('debug')(`${require('./package.json').name}:expect-env`);

jest.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   restoreMocks: true,
   resetMocks: true,

lint-staged.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   '*.md': 'remark -o --use reference-links --use gfm --use frontmatter',
   'package.json': 'sort-package-json',

next.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const withBundleAnalyzer = require('@next/bundle-analyzer');
 const { verifyEnvironment } = require('./expect-env');
 

prettier.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 module.exports = {
   endOfLine: 'lf',
   printWidth: 80,

release.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const debug = require('debug')(
   `${require('./package.json').name}:semantic-release-config`
 );

spellcheck-commit.js

@@ -1,4 +1,6 @@
+'use strict';
 /* eslint-disable no-console */
+
 const spellcheck = require('spellchecker');
 const pkg = require('./package.json');
 const read = require('fs').promises.readFile;

webpack.config.js

@@ -1,3 +1,5 @@
+'use strict';
+
 // This webpack config is used to transpile src to dist, compile externals,
 // compile executables, etc
 
@@ -7,22 +9,30 @@ const { verifyEnvironment } = require('./expect-env');
 const nodeExternals = require('webpack-node-externals');
 const debug = require('debug')(`${require('./package.json').name}:webpack-config`);
 
-let env = {};
+let sanitizedEnv = {};
+let { NODE_ENV, ...sanitizedProcessEnv } = { ...process.env, NODE_ENV: 'production' };
 
 try {
   require('fs').accessSync('.env');
-  env = require('dotenv').config().parsed;
-  debug('new env vars: %O', env);
+  ({ NODE_ENV, ...sanitizedEnv } = require('dotenv').config().parsed);
+  debug(`NODE_ENV: ${NODE_ENV}`);
+  debug('sanitized env: %O', sanitizedEnv);
 } catch (e) {
   debug(`env support disabled; reason: ${e}`);
 }
 
 verifyEnvironment();
 
 const envPlugins = [
+  // ? NODE_ENV is not a "default" (unlike below) but an explicit overwrite
+  new DefinePlugin({
+    'process.env.NODE_ENV': JSON.stringify(NODE_ENV)
+  }),
   // ? Load our .env results as the defaults (overridden by process.env)
-  new EnvironmentPlugin({ ...env, ...process.env }),
-  // ? Create shim process.env for undefined vars (per my tastes!)
+  new EnvironmentPlugin({ ...sanitizedEnv, ...sanitizedProcessEnv }),
+  // ? Create shim process.env for undefined vars
+  // ! The above already replaces all process.env.X occurrences in the code
+  // ! first, so plugin order is important here
   new DefinePlugin({ 'process.env': '{}' })
 ];