Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make executeSlicesUntilClumpsFinished failure test have a reliable failure mode #683

Open
Devika-Tantry opened this issue Jun 22, 2021 · 0 comments

Comments

@Devika-Tantry
Copy link
Contributor

Devika-Tantry commented Jun 22, 2021

The test The Vireo EggShell executeSlicesUntilClumpsFinished API reports error when the Vireo runtime stops execution test is intended to verify that the user can correctly observe both graceful errors and critical errors in Vireo execution. As Vireo runs asynchronously this test is useful to make sure that both graceful errors and exceptions are reported correctly to asynchronous callers.

Currently the test triggers a critical failure by assuming that a large allocation will cause a segmentation fault. This behavior is not reliable as we may change large allocation failure modes in the future. An instruction should be added that can explicitly trigger a segmentation fault so the test can verify handling of critical Vireo failures.

@rajsite rajsite changed the title Fix executeSlicesUntilClumpsFinished.Test.js Test Make executeSlicesUntilClumpsFinished failure test have a reliable failure mode Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants