You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While developing the chat components I hit build issues in Storybook caused by a dependency I introduced from spright-components to nimble-components. For the chat components I worked around it by eliminating the dependency but that's not a viable long term strategy.
The problem is caused by the different ways that the storybook package and the spright-components package import content from nimble-components. All the storybook imports are relative paths to source (to keep turbosnap working) but all the components imports are package imports @ni/nimble-components (to ensure correct package dependencies in the build output). This results in 2 copies of nimble-components classes being pulled in to the storybook build, which leads to type conflicts.
@rajsite thought we might be able to use tsconfig type mappings similar to what we do in SystemLinkShared. We would apply this to storybook's config to map package paths to the corresponding relative paths. We should try this out and see if we can get the build and turbosnap working together.
The text was updated successfully, but these errors were encountered:
🧹 Tech Debt
While developing the chat components I hit build issues in Storybook caused by a dependency I introduced from spright-components to nimble-components. For the chat components I worked around it by eliminating the dependency but that's not a viable long term strategy.
The problem is caused by the different ways that the storybook package and the spright-components package import content from nimble-components. All the storybook imports are relative paths to source (to keep turbosnap working) but all the components imports are package imports
@ni/nimble-components
(to ensure correct package dependencies in the build output). This results in 2 copies of nimble-components classes being pulled in to the storybook build, which leads to type conflicts.@rajsite thought we might be able to use tsconfig type mappings similar to what we do in SystemLinkShared. We would apply this to storybook's config to map package paths to the corresponding relative paths. We should try this out and see if we can get the build and turbosnap working together.
The text was updated successfully, but these errors were encountered: