Skip to content
This repository has been archived by the owner on Apr 8, 2024. It is now read-only.

Do not use absolute paths for install #34

Open
Lectem opened this issue Jul 27, 2015 · 6 comments
Open

Do not use absolute paths for install #34

Lectem opened this issue Jul 27, 2015 · 6 comments
Assignees

Comments

@Lectem
Copy link
Contributor

Lectem commented Jul 27, 2015

Absolute paths breaks CPack, any project including hayai with add_subdirectory would not be able to use CPack.

@nickbruun
Copy link
Owner

I'm going to need a little more detail on this. I can't seem to find any place where absolute paths are used?

@Lectem
Copy link
Contributor Author

Lectem commented Jul 27, 2015

All paths are converted to absolute ones here : https://github.com/nickbruun/hayai/blob/master/CMakeLists.txt#L20-L26

The problem it triggers is described here : http://www.cmake.org/Bug/view.php?id=15665

@nickbruun
Copy link
Owner

Ah, you are absolutely right. I missed that one. I'll look into it and get it fixed :)

Thanks for yet another stellar catch!

@nickbruun nickbruun self-assigned this Jul 27, 2015
@Lectem
Copy link
Contributor Author

Lectem commented Jul 27, 2015

You're welcome ! Hayai is pretty cool, so it'd be sad to have tiny things make it look bad =)

@nickbruun
Copy link
Owner

Thanks ;) yea, let's get these things ironed out :) what system are you developing on (just out of curiosity)?

@Lectem
Copy link
Contributor Author

Lectem commented Jul 27, 2015

Linux Mint LMDE at work, Windows mingw32-64 at home. Have not tested hayai on windows yet though.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants