Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warning for combo variables #197

Open
FabianoLothor opened this issue Mar 14, 2024 · 1 comment
Open

Warning for combo variables #197

FabianoLothor opened this issue Mar 14, 2024 · 1 comment

Comments

@FabianoLothor
Copy link

FabianoLothor commented Mar 14, 2024

I recently got an issue when creating multiple combos for the same thumb keys due the value of CONFIG_ZMK_COMBO_MAX_COMBOS_PER_KEY.

Its default value is 5: https://zmk.dev/docs/config/combos

I'd 7 macros configured for the same keys and it took me some time until I figure out what was the issue.

Do you see any value in add some sort of warning when this happens?

We also have:

  • CONFIG_ZMK_COMBO_MAX_PRESSED_COMBOS default 4;
  • CONFIG_ZMK_COMBO_MAX_KEYS_PER_COMBO default 4;

Certainly this doesn't happen often and I would consider it just a "nice to have" feature.

I know ZMK restricts other things through variables, so maybe this request could be extended to something more wide.

@nickcoutsos
Copy link
Owner

Definitely a nice to have. The trouble for me in the short term is that although we have these configurations to look at and they're all well documented, there are so many places where the configuration could exist and could change between fetches that it ends up being a lot of API calls.

Eventually this would be a non-issue because all of the data I need will come directly from the keyboard through ZMK Studio's protocol.

As a short term thing I might use the defaults as "typical" limits and present warnings in the UI that make it clear individual users may have different setups, linking to relevant documentation for additional details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants