Limit concurrent calls to ffmpeg

[schickm]

Right now there is no limit to how many concurrent calls are made to ffmpeg.ffprobe. If you are reading the tags of a large library for the first time, the node process will crash due to requesting too many file handles.

I brought this up to the node-fluent-ffmpeg people and they said to "not my problem", so I plan on submitting a pull request which wraps the calls in async.queue to fix this issue.

[nickdesaulniers]

I think I fixed this in a separate branch I have yet to merge into master.

[schickm]

Found your fix. You're just using your own patched version of fluent-ffmpeg. Going about it the async method was pretty easy, you can checkout my commit here. Any reason why you went about it that way? Patching such a big library like fluent-ffmpeg seems a little drastic:scream_cat:.

[nickdesaulniers]

LOL I tried to fix it in ffmpeg and upstream it, but the patch was rejected.

Any reason why you went about it that way? Patching such a big library like fluent-ffmpeg seems a little drastic:scream_cat:.

Is that not how open source should work?

[schickm]

Yah, I saw your upstream patch to ffmpeg and their rejection. I can see it from both sides.

I'm setting up an install of audiostream at the Old Town School of Folk Music in Chicago for them to use internally to stream their live recordings catalog...thus my little spurts of questions/comments with your project. Figured it'd be nice to hear about people using it in production.

thanks for the hard work!

[nickdesaulniers]

Glad someone is testing it out. Hope it works for you guys. Let me know how they find it. One of these days I'll get around to refreshing the UI.