Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to change between imperial or metric units #4

Open
nicolasperez19 opened this issue Oct 25, 2024 · 0 comments · May be fixed by #27
Open

Add ability to change between imperial or metric units #4

nicolasperez19 opened this issue Oct 25, 2024 · 0 comments · May be fixed by #27
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
Enhancements

Comments

@nicolasperez19
Copy link
Owner

It might be nice to add a comment to the numpy array so that you know what type of units the positions are in.

For instance, if the units are metric units it would say:

np.array([
  [-0.0333, 1.0250],
  [0.5500, 0.4250],
  [-0.0500, -0.5083],
  [-0.9833, -0.0083]
]) # positions in meters
@nicolasperez19 nicolasperez19 added the enhancement New feature or request label Oct 25, 2024
@nicolasperez19 nicolasperez19 added this to the Enhancements milestone Oct 25, 2024
@nicolasperez19 nicolasperez19 added the good first issue Good for newcomers label Oct 30, 2024
nkzarrabi referenced this issue in nkzarrabi/mic-master-flex Oct 31, 2024
@nkzarrabi
Add ability to change between imperial or metric units
f2e01e0 
Fixes #4

Add ability to change between imperial or metric units in the numpy array.

* Add a dropdown in `src/components/MicMasterFlex.tsx` to select between metric and imperial units.
* Update the `getNumpyArrayString` function to include a comment indicating the units.
* Update the `copyToClipboard` function to include the unit comment.

---

For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/nicolasperez19/mic-master-flex/issues/4?shareId=XXXX-XXXX-XXXX-XXXX).
@nkzarrabi nkzarrabi linked a pull request Oct 31, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
Enhancements
Development

Successfully merging a pull request may close this issue.

Add ability to change between imperial or metric units nkzarrabi/mic-master-flex
1 participant
@nicolasperez19