Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bedrock projects are not being recognized #287

Closed
1 task done
chrillep opened this issue Jun 6, 2024 · 2 comments 路 Fixed by #288
Closed
1 task done

[Bug] Bedrock projects are not being recognized #287

chrillep opened this issue Jun 6, 2024 · 2 comments 路 Fixed by #288
Assignees
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!

Comments

@chrillep
Copy link
Contributor

chrillep commented Jun 6, 2024

Hello! 馃憢馃徏

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

roots/bedrock dependency is not part of composer.json in bedrock projects.
https://github.com/roots/bedrock/blob/8d4d3cf2a6ac03e770398f14ed3ad0a184c038d9/composer.json#L33-L44

so this check wont work.

roots/bedrock-autoloader however is used as a dependency and should be available in all bedrock projects.

the valet driver for bedrock checks for these paths
https://github.com/laravel/valet/blob/78657cdb35ae327dbf1fdb3a74227be0b2ed0dfa/cli/Valet/Drivers/Specific/BedrockValetDriver.php#L14-L18

Expected Behavior

No response

Steps To Reproduce

No response

Environment

- macOS:
- Valet:
- PHP Monitor:

Do you have a log file (or a screenshot) or any additional information?

No response

@chrillep chrillep added the bug Something isn't working (correctly). label Jun 6, 2024
@nicoverbruggen
Copy link
Owner

Thanks for catching this!

@nicoverbruggen nicoverbruggen added the fixed in upcoming release Fixed in the upcoming release! label Jun 6, 2024
@nicoverbruggen
Copy link
Owner

This is now fixed and available in the latest version of PHP Monitor, version 7.0.4. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (correctly). fixed in upcoming release Fixed in the upcoming release!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants