Embedded libraries: Nightingale should use libraries from the system in Linux

[sergiobenrocha2]

In Linux, Nightingale should use the libraries from the system, not the embedded:

libsqlite3.so: sqlite
libnss3.so: nss
libxul.so: zlib
libxul.so: libtheora
libxul.so: libjpeg
updater: bzip2

This is a problem to security fixes, and debian packaging complains about it. Nightingale probably never goes to debian repo with these issues.

erlepereira is working in sqlite: https://github.com/erlepereira/nightingale-hacking/commits/sb-trunk-oldxul

[needs-packaging] nightingale in Launchpad: https://bugs.launchpad.net/ubuntu/+bug/1190146

[sergiobenrocha2]

issue #210 have this problem about sqlite.

[thebecwar]

It's more complicated than that. In some cases the system libraries are completely incompatible with our source and cause intermittent behavior and crashes. (See #299 for an example of this.) On these systems, we have to use bundled libraries.

[thebecwar]

From the bug report you linked to:

Martin Giger (freaktechnik) wrote on 2014-06-23: #9
We'll hopefully be able to get rid of some of the stuff in the deps in the future, but for example debian's taglib is giving us a lot of trouble (same with sqlite).

[darealshinji]

Might wanna take a look at nightingale-media-player/nightingale-deps#21
The xulrunner build that the build script is using is probably still the old one. There's now a way to compile a more Debian friendly version of it. If you want pre-compiled archives, look at the nightingale-deps package on my PPA: https://launchpad.net/~djcj/+archive/ubuntu/nightingale/+packages

IMO the "libnss3.so: nss" and "libsqlite3.so: sqlite" warnings can be overridden, as they're not embedded libraries as the Lintian error implies but dynamic private libs. I agree with replacing them with system libs if possible, but afaik for now it only works this way.

[freaktechnik]

Closing here, as these are issues with embedded libraries in deps (as xulrunner will always have to be embedded now) and SQLite is tracked separately here.