Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Having Frames with Artifacts (rgb-like) #8

Open
Tsubajashi opened this issue Oct 24, 2020 · 22 comments
Open

Having Frames with Artifacts (rgb-like) #8

Tsubajashi opened this issue Oct 24, 2020 · 22 comments

Comments

@Tsubajashi
Copy link

Hi!
For some odd reason, no matter the settings (as far as i tested) i get various frames (where a blend from scene to scene would appear) where i get artifacts like these:
000286
000430
The more i increase the tile size, the less it gets. Issue here is that tile size 2048 seems to be the limit and nothing changes after that anymore.
Does anyone have any idea how to fix that up?

@routineLife1
Copy link

或许你可以尝试使用CAIN而不用cain-ncnn-vulkan

@Tsubajashi
Copy link
Author

isnt the "standard" CAIN nvidia only? i only have an amd card at hand.

@Mar2ck
Copy link

Mar2ck commented Nov 4, 2020

Yes CAIN uses CUDA which is Nvidia only.
It's normal for any interpolation software to output weird results for scene changes since it's trying to interpret motion where there is none. You should be using the highest tilesize you can that doesn't give vk errors so that you get the best speed/quality, -t 2048 is already bigger then 1920x1080 so higher numbers wont change anything

@Tsubajashi
Copy link
Author

That I can get behind, but shouldn't it affect the entire frame then? I think I'll let that clip run through dain to see if there are similar results, because i think there's something off.
That, or I'll try to find another solution which still interpolates well, but might be more artifacting. Dunno which ones to pick from though.

@Mar2ck
Copy link

Mar2ck commented Nov 4, 2020

The frames you posted have blocks of 512x512 so either you used -t 512 or something is broken

@Tsubajashi
Copy link
Author

thats what i was guessing. i did use -t 2048 though. should i set it to 1920 and test it again?

@Mar2ck
Copy link

Mar2ck commented Nov 4, 2020

I wouldn't expect it to make a difference but you could try. 512 is the default tilesize so it seems like the -t option is getting ignored for some reason

@routineLife1
Copy link

Doesn't the tilesize have to be divisible by 32?

@routineLife1
Copy link

I trained a new CAIN model, but I don’t know how to convert the pytorch model to the ncnn model

@routineLife1
Copy link

I used CAIN to make up a video, here is the link: https://drive.google.com/file/d/1w-4oU9e-LSU2JSCSbulX0Dueqdiv2Czc/view?usp=sharing

@Mar2ck
Copy link

Mar2ck commented Nov 4, 2020

I trained a new CAIN model, but I don’t know how to convert the pytorch model to the ncnn model

https://github.com/Tencent/ncnn/wiki/use-ncnn-with-pytorch-or-onnx

@routineLife1
Copy link

It's a bit difficult for me ε(┬┬﹏┬┬)3

@routineLife1
Copy link

https://drive.google.com/file/d/1gazwEvXVVEzAwSORoMzPhihj1ylfQzVN/view?usp=sharing

@n00mkrad
Copy link

I still have this problem.
What was on the link posted above? It's 404.

@Tsubajashi
Copy link
Author

Just found out, on the same hardware and same video, i didnt experience it in linux

@nihui
Copy link
Owner

nihui commented Dec 5, 2020

please try the latest artifact

@Tsubajashi
Copy link
Author

still happening, see #12

@routineLife1
Copy link

routineLife1 commented Dec 20, 2020

@Tsubajashi
Copy link
Author

@YiWeiHuang-stack how does one use that trained model on cain-ncnn? i dont seem to understand how it would be implemented.

@Tsubajashi
Copy link
Author

Bumping up this issue - the problem still exists, sadly. Could you check if new NCNN versions or anything, really, improves on this issue?

@Hudaldadi
Copy link

It seems to be the resolution - since I have choose a resolution divide able by 128 it worked for me.

And having a monitor connected to each GPU you want to use also solved it for me.

@Tsubajashi
Copy link
Author

Im pretty sure that 1920x1080 and 1280x720 should be supported. Happened across each and every file I have tested, across several OS. Glad it work for you, though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants