-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Motivation? #14
Comments
The original implementation based on resource-pool required hacks to accommodate to the requirements of resource-pool. It had something to do with exceptions but I don't remember precisely. There were several issues caused by those hacks, which you can see in the closed issues of this tracker. At some point I realised that it would be easier to just implement the pool directly. As you can see in the source code, the whole implementation now is like 80 lines of code. |
@istathar FYI, as I still need to rely on @nikita-volkov given |
@avanov I've answered to your question in the according issue linked above. Thanks for bringing this up! |
Hey Nikita. I hesitated to ask this because I can see you've been working really hard to refine hasql-pool. I'm sure you're aware (but maybe you're not) that resource-pool was adopted and resuscitated by the community. Notably
scrive/master
bos/pool#45 andwith the result that a 0.3.0 has been released to Hackage with a number of performance and correctness fixes.
I assume you want nothing to do with it at this point, but we're using resource-pool elsewhere in our system and so noticed that suddenly hasql-pool wasn't anymore. Which is entirely fine but hey, thought I'd mention. Go ahead and close this
:)
. All the best.The text was updated successfully, but these errors were encountered: