3.0.10

Fixing #3923

Author: nilsteampassnet

includes/config/include.php

@@ -17,7 +17,7 @@
  */
 define('TP_VERSION', '3.0.10');
 define("UPGRADE_MIN_DATE", "1697990713");
-define('TP_VERSION_MINOR', '130');
+define('TP_VERSION_MINOR', '131');
 define('TP_TOOL_NAME', 'Teampass');
 define('TP_ONE_DAY_SECONDS', 86400);
 define('TP_ONE_WEEK_SECONDS', 604800);

includes/config/settings.sample.php

@@ -7,7 +7,15 @@
 define("DB_PREFIX", "");
 define("DB_PORT", "");
 define("DB_ENCODING", "utf8");
-define("DB_SSL", false);
+define("DB_SSL", false); // if DB over SSL then comment this line
+// if DB over SSL then uncomment the following lines
+//define("DB_SSL", array(
+//    "key" => "",
+//    "cert" => "",
+//    "ca_cert" => "",
+//    "ca_path" => "",
+//    "cipher" => ""
+//));
 define("DB_CONNECT_OPTIONS", array(
     MYSQLI_OPT_CONNECT_TIMEOUT => 10
 ));

index.php

@@ -25,8 +25,6 @@
  */
 
 use TeampassClasses\SuperGlobal\SuperGlobal;
-use EZimuel\PHPSecureSession;
-use TeampassClasses\PerformChecks\PerformChecks;
 
 header('X-XSS-Protection: 1; mode=block');
 header('X-Frame-Options: SameOrigin');
@@ -80,7 +78,6 @@
 require_once __DIR__.'/sources/main.functions.php';
 
 // init
-loadClasses('DB');
 $superGlobal = new SuperGlobal();
 
 // Quick major version check -> upgrade needed?
@@ -95,7 +92,6 @@
     exit;
 }
 
-$superGlobal = new SuperGlobal();
 
 if (isset($SETTINGS['cpassman_url']) === false || $SETTINGS['cpassman_url'] === '') {
     $SETTINGS['cpassman_url'] = $superGlobal->get('REQUEST_URI', 'SERVER');

install/upgrade.php

@@ -515,7 +515,7 @@ function getSettingValue($val)
 
     echo '
         <div class="mt-5">
-        <a href="#" class="btn btn-primary" onclick="javascript:window.location.href=\'', (isset($_SERVER['HTTPS']) && ($_SERVER['HTTPS'] == 'on' || $_SERVER['HTTPS'] == 1) || isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https') ? 'https' : 'http', '://'.$_SERVER['HTTP_HOST'].substr($_SERVER['PHP_SELF'], 0, strrpos($_SERVER['PHP_SELF'], '/') - 8).'\';"><b>Open TeamPass</b></a>
+        <a href="#" class="btn btn-primary" onclick="javascript:window.location.href=\'', (isset($_SERVER['HTTPS']) && ($_SERVER['HTTPS'] == 'on' || $_SERVER['HTTPS'] == 1) || isset($_SERVER['HTTP_X_FORWARDED_PROTO']) && $_SERVER['HTTP_X_FORWARDED_PROTO'] == 'https') ? 'https' : 'http', '://'.$_SERVER['HTTP_HOST'].substr($_SERVER['PHP_SELF'], 0, strrpos($_SERVER['PHP_SELF'], '/') - 8).'/index.php\';"><b>Open TeamPass</b></a>
         </div>';
 }
 

install/upgrade_run_3.0.0.php

@@ -891,7 +891,7 @@
     "ADD KEY `CACHE` (`increment_id`, `user_id`)"
 );
 if (!$res) {
-    echo '[{"finish":"1", "msg":"", "error":"An error appears when adding the INDEX CACHE to the cache_tree table! ' . mysqli_error($db_link) . '!"}]';
+    echo '[{"finish":"1", "msg":"", "error":"An error appears when adding the INDEX CACHE to the cache_tree table! ' . addslashes(mysqli_error($db_link)) . '!"}]';
     mysqli_close($db_link);
     exit();
 }

sources/core.php

@@ -28,11 +28,9 @@
 use voku\helper\AntiXSS;
 use TeampassClasses\SuperGlobal\SuperGlobal;
 use EZimuel\PHPSecureSession;
-use TeampassClasses\PerformChecks\PerformChecks;
 
 // Load functions
 require_once 'main.functions.php';
-loadClasses('DB');
 $superGlobal = new SuperGlobal();
 
 // Load config if $SETTINGS not defined
@@ -42,8 +40,6 @@
     throw new Exception("Error file '/includes/config/tp.config.php' not exists", 1);
 }
 
-// Include files
-$superGlobal = new SuperGlobal();
 
 /**
  * Redirection management.
@@ -52,7 +48,7 @@
  *
  * @return string refresh page to url
  */
-function redirect($url)
+function teampassRedirect($url)
 {
     // Load AntiXSS
     $antiXss = new AntiXSS();
@@ -91,7 +87,7 @@ function redirect($url)
     && isset($SETTINGS['enable_sts']) === true
     && (int) $SETTINGS['enable_sts'] === 1
 ) {
-    redirect('https://' . $server['http_host'] . $server['request_uri']);
+    teampassRedirect('https://' . $server['http_host'] . $server['request_uri']);
 }
 
 // Load pwComplexity