Skip to content

Commit cab2864

Browse files
authored
added message when addSampler doesnt assign for data nodes (#1580)
1 parent 6e6d799 commit cab2864

1 file changed

Lines changed: 12 additions & 2 deletions

File tree

packages/nimble/R/MCMC_configuration.R

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -787,8 +787,18 @@ The second usage of \'multivariateNodesAsScalars\' occurs when \'default\' is TR
787787
For internal use only
788788
'
789789
if(!allowData && !allowData_global) {
790-
if(all(model$isData(targetOne))) return()
791-
if(any(model$isData(targetOne))) targetOne <- filterOutDataNodes(targetOne)
790+
if(all(model$isData(targetOne))) {
791+
messageIfVerbose(paste0(' [Note] Samplers not added to data node: ', paste0(targetOne, collapse = ', '), '.'))
792+
messageIfVerbose(paste0(' Provide argument allowData = TRUE to addSampler method, to force sampler assignment.'))
793+
return()
794+
}
795+
if(any(model$isData(targetOne))) {
796+
targetWithSomeData <- model$expandNodeNames(targetOne)
797+
targetOne <- filterOutDataNodes(targetOne) ## this is the salient step of this entire block
798+
targetDataComponents <- setdiff(targetWithSomeData, targetOne)
799+
messageIfVerbose(paste0(' [Note] Samplers not added to data node: ', paste0(targetDataComponents, collapse = ', '), '.'))
800+
messageIfVerbose(paste0(' Provide argument allowData = TRUE to addSampler method, to force sampler assignment.'))
801+
}
792802
}
793803
newInd <- length(samplerConfs) + 1
794804
samplerConfs[[newInd]] <<- samplerConf(name=thisSamplerName, samplerFunction=samplerFunction, target=targetOne, control=thisControlList, model=model)

0 commit comments

Comments
 (0)