Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propagate TR from BIDS structure to NIfTI dims #515

Open
oesteban opened this issue May 7, 2020 · 3 comments
Open

Propagate TR from BIDS structure to NIfTI dims #515

oesteban opened this issue May 7, 2020 · 3 comments
Labels
BIDS & Derivatives effort:low Estimated low effort task impact:medium Estimated medium impact task
Milestone

Comments

@oesteban
Copy link
Member

oesteban commented May 7, 2020

Transfer from nipreps/fmriprep#1093.

@effigies
Copy link
Member

effigies commented May 8, 2020

This may be obviated by running the BIDS validator first, which will error when the TR doesn't match RepetitionTime or RepetitionTime is missing.

@oesteban
Copy link
Member Author

oesteban commented May 8, 2020

Not really, metadata can be lost (e.g., split and merge). Having this convenience tool will come handy. We're checking other things (units, dtype, xforms...).

@effigies
Copy link
Member

effigies commented May 8, 2020

I guess let's be explicit: You're saying that sometimes we find derivatives don't have pixdim4 set, but other times we do? What could it be conditional on, if not the presence of pixdim4 in the original files, which is checked by the validator? A test case would be useful.

I would also consider it problematic for splitting or merging interfaces to change or lose pixdim4. That would be a good thing to fix, as it's possible that somewhere between validation and sinking derivatives we'll have jobs that actually need the TR. We can pass the TR to some interfaces, but it is metadata that should be stored accurately in the header.

@oesteban oesteban added this to the 1.4.0 milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BIDS & Derivatives effort:low Estimated low effort task impact:medium Estimated medium impact task
Projects
None yet
Development

No branches or pull requests

2 participants