Gush neighbours #48
Open
OrenKishon wants to merge 214 commits intoniryariv:masterfrom
OrenKishon:master
Open
Conversation
…e branch 'master' into gh-pages
Adding .json suffix to gush plans URL to support new opentaba-server API
Collaborator
|
@oreniko Thanks! do you why the test fail? can you seperate the demo example from the app code? so we won't break functionality for users when we merge? can you add a test for the new function (or explain the algo so I can write one?) |
Collaborator
|
@oreniko also wandering - the neighbours script? shouldn't it run in the server? and not in the frontend? the frontend doesn't run python |
Owner
|
we could have on opentaba-server, and just run the script whenever we import a new municipality - each gush will have an array of neighbors in the DB. what do you think? |
Collaborator
florpor
force-pushed
the
master
branch
3 times, most recently
from
576a93a to
21f806a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a hard coded example of Ashkelon.