Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Digital communications nismod integration tests #40

Open
3 tasks
tomalrussell opened this issue Feb 11, 2019 · 0 comments
Open
3 tasks

Digital communications nismod integration tests #40

tomalrussell opened this issue Feb 11, 2019 · 0 comments

Comments

@tomalrussell
Copy link
Member

tomalrussell commented Feb 11, 2019

Child of #55

Tasks:

  • See nismod-2 errors on master checkout

  • integration tests to pass

  • email Ron Fowler at STFC

    The abstract class error looks like the DigitalCommsWrapper hasn't fully implemented the
    SectorModel interface.

The data interfaces for smif have also been changing faster than the sector model prototypes.
Over the next 3-6months each model should be getting to a more mature state and integration
will be a focus over that time.

The configuration errors relate to the scenario data format, which is another area under active
development as Craig Robson (Newcastle) is working on the database backend to have as
alternative option to our first-prototype YAML file inputs.

E  TypeError: Can't instantiate abstract class DigitalCommsWrapper with abstract methods
initialise /usr/local/lib/python3.5/dist-packages/smif/sector_model.py:243: TypeError

The model configuration was invalid
Captured stderr call
ERROR    Expected a
value for 'interval' in each data point in a scenario, only received {'region': 'England',
'year': 2010, 'units': 'people', 'value': 52000000} ERROR    Expected a value for 'interval' in
each data point in a scenario, only received {'region': 'Scotland', 'year': 2010, 'units':
'people', 'value': 5100000}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants