Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

decisions: decision module should have access to parameters #328

Open
1 task done
willu47 opened this issue Mar 20, 2019 · 0 comments
Open
1 task done

decisions: decision module should have access to parameters #328

willu47 opened this issue Mar 20, 2019 · 0 comments
Labels
feature:decisions Decision framework

Comments

@willu47
Copy link
Member

willu47 commented Mar 20, 2019 •
edited
Loading

Update - PR #339 implements a results_handle.get_state() method.

Call to get_parameter() is still outstanding.

  • A call to results_handle.get_data() should enable access to scenario data from a decision module.

Blocks nismod/nismod2#53 as digital comms decision module requires access to adoption scenario data, based on strategy chosen.

Above no longer correct as get_results can be used to obtain information from output of model, but it would be very useful if the decision module has access to parameters though a result_handle.get_parameter() method

See also #333
willu47 added a commit to nismod/nismod2 that referenced this issue Mar 22, 2019
@willu47
Merge pull request #67 from willu47/wrap/dc_fixed
333e8da 
Update digital comms wrapper

To do:

- smif decision module access to scenario data - see nismod/smif#328
- nismod digital_comms adoption scenario data provision from FTP -
@willu47 willu47 changed the title decisions: decisionmodule should have access to scenario data decisions: decision module should have access to parameters and previous_state Mar 27, 2019
@willu47 willu47 mentioned this issue Mar 27, 2019
Merged
5 tasks
@willu47 willu47 changed the title decisions: decision module should have access to parameters and previous_state decisions: decision module should have access to parameters Apr 8, 2019
@willu47 willu47 added this to the A Generic Decision Framework milestone Apr 10, 2019
@tomalrussell tomalrussell added feature:decisions Decision framework and removed enhancement labels Aug 5, 2019
@tomalrussell tomalrussell removed this from the A Generic Decision Framework milestone Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature:decisions Decision framework
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tomalrussell @willu47