-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
error installation Error: 'srcdir' should be: 'srcDir'
#55
Comments
I think this was fixed in nimble[0], however the latest release is older than the fix. That said, I cannot reproduce the error. |
you have stylecheck:error in your config, probably |
mmh the stylecheck checking every dependency, even Nim itself instead of the project/app/lib being built is a PITA. |
What if we rename
I guess that should fix nimble-package CI, but it won't help those using the style checker. |
Agreed - best to change regex.nimble to |
I just did that. Let me know if it's fixed now. |
I did this: when (NimMajor, NimMinor) >= (1, 1):
srcDir = "src"
else:
srcdir = "src" Now it fails for me with |
Koch pulls a specific Nimble commit - https://github.com/nim-lang/Nim/blob/devel/koch.nim#L137. Only if run with --latest, does it pull latest Nimble. Seems like you need to turn off the style check as well. |
@genotrance Why does Nimble care about this anyway? Nim is style insensitive, why isn't Nimble? |
@dom96: His config makes Nim care. https://github.com/nitely/nim-regex/blob/master/config.nims#L4 |
That won't quite work. Users import nim-regex and then compile their programs with the stylecheck on, and AFAIK nim-regex gets stylechecked as well. That'll fail depending on the Nim version, and I'll receive complains. I didn't try this, though, may be it won't fail? I'll try it later. |
Most people aren't keeping |
See #40. I guess I should remove that config, and just reject PRs fixing style... |
@kaushalmodi - what's your take on this? @dom96 - changing |
@genotrance Unless the packages (like regex) pass the stylechecks, the users cannot use I like consistencies and enforce styleCheck:error in my config. If the nimble and other popular packages cannot play well with styleCheck:error, they may be that feature should be removed. My take would be to do whatever is needed to make styleCheck:error work. How can I help there? |
I appreciate your point of view and that packages like nim-regex could conform so that users can use the flag. That being said, the whole point of Nim's style insensitivity is to allow users and packages the flexibility that they prefer and not impose it on others. Regardless, I don't want to make it a big discussion around this feature. @Araq can share his thoughts on this in general. The specific question here is that Nimble recently changed Not sure how to proceed here. Ideas appreciated. |
It looks like removing |
@nitely I apologize for my PR causing all this trouble. |
I've removed the config for the time being 4360c26 |
So use |
The text was updated successfully, but these errors were encountered: