From 62d62c71c206b644150ce030c37513f83b3d2ede Mon Sep 17 00:00:00 2001 From: Tim Holm Date: Fri, 12 Apr 2024 09:55:35 +1000 Subject: [PATCH] fix: Don't overwrite blobRequest event fields (#225) Also fix missing bucket reference for bucket references with permissions when adding notifications. --- src/api/storage/v1/storage.ts | 2 +- src/resources/bucket.ts | 7 ------- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/src/api/storage/v1/storage.ts b/src/api/storage/v1/storage.ts index 677c25f..bd5e4a9 100644 --- a/src/api/storage/v1/storage.ts +++ b/src/api/storage/v1/storage.ts @@ -120,7 +120,7 @@ export class Bucket { notificationPrefixFilter, ...middleware ); - return notification['start'](); + return notification['start'](this); } } diff --git a/src/resources/bucket.ts b/src/resources/bucket.ts index 452ef07..965a31d 100644 --- a/src/resources/bucket.ts +++ b/src/resources/bucket.ts @@ -33,7 +33,6 @@ import { ClientMessage, RegistrationRequest, ServerMessage, - BlobEvent, BlobEventResponse, } from '@nitric/proto/storage/v1/storage_pb'; import { StorageListenerClient } from '@nitric/proto/storage/v1/storage_grpc_pb'; @@ -138,12 +137,6 @@ export class BucketNotification { responseMessage.setId(message.getId()); try { - blobEventRequest.setBucketName(this.options.bucket); - const blobEvent = new BlobEvent(); - blobEvent.setKey(this.options.notificationPrefixFilter); - blobEvent.setType(this.options.notificationType); - blobEventRequest.setBlobEvent(blobEvent); - if (bucket) { const ctx = BlobEventContext.fromRequest( blobEventRequest,