From 256708538ca49d269f271a636a3c436e1986a584 Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Mon, 4 Mar 2024 15:39:34 +1000 Subject: [PATCH 1/2] increase nixpkgs-review timeout to 120 minutes --- src/NixpkgsReview.hs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/NixpkgsReview.hs b/src/NixpkgsReview.hs index 34f914d..c8e7d2c 100644 --- a/src/NixpkgsReview.hs +++ b/src/NixpkgsReview.hs @@ -34,7 +34,7 @@ run :: Text -> Sem r Text run cache commit = - let timeout = "45m" :: Text + let timeout = "120m" :: Text in do -- TODO: probably just skip running nixpkgs-review if the directory -- already exists From 5b653712225a9c4a8abc21a9c2deec3da5507c30 Mon Sep 17 00:00:00 2001 From: zowoq <59103226+zowoq@users.noreply.github.com> Date: Sun, 17 Mar 2024 12:50:37 +1000 Subject: [PATCH 2/2] increase python max package rebuilds from 25 to 100 --- doc/nixpkgs-maintainer-faq.md | 2 +- src/Skiplist.hs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/nixpkgs-maintainer-faq.md b/doc/nixpkgs-maintainer-faq.md index c2c3c92..4f0ccf3 100644 --- a/doc/nixpkgs-maintainer-faq.md +++ b/doc/nixpkgs-maintainer-faq.md @@ -36,7 +36,7 @@ Updates can be disabled by adding a comment to the package: We maintain a [Skiplist](https://github.com/ryantm/nixpkgs-update/blob/main/src/Skiplist.hs) of different things not to update. It is possible your package is triggering one of the skip criteria. -Python updates are skipped if they cause more than 25 rebuilds. +Python updates are skipped if they cause more than 100 rebuilds. ### Existing Open or Draft PR diff --git a/src/Skiplist.hs b/src/Skiplist.hs index bdba1cc..78fc1b6 100644 --- a/src/Skiplist.hs +++ b/src/Skiplist.hs @@ -234,4 +234,4 @@ python numPackageRebuilds derivationContents = (not isPython || numPackageRebuilds <= maxPackageRebuild) where isPython = "buildPythonPackage" `T.isInfixOf` derivationContents - maxPackageRebuild = 25 + maxPackageRebuild = 100