Conversation
b97de9a to
c27a42e
Compare
|
The CI is broken:( |
Weird, let me take a look |
Hello, @SteveLauC , if you are still looking at this:) I think it's because the latest version of |
So was this newer version of |
I don't think so. This repo doesn't commit the However, it seems that |
|
Just re-ran the CI, and they failed because |
|
Weird, the FreeBSD CI was still using once_cell 1.21.0 🤔 https://github.com/nix-rust/nix/pull/2610/checks?check_run_id=38692242745 |
Failed 5 days ago. Not today. |
Hmm, sorry for missing that:D |
|
Thank you @SteveLauC , now the CI passes again. |
SteveLauC
left a comment
There was a problem hiding this comment.
Sorry for the late review, the code part looks good. For the tests, some of them are "ignored" even though the corresponding symbols are available, I would like to know why, and if possible, it would be great to comment on the reason there, which would help maintenance a lot! :)
|
Let me fix the unrelated nightly clippy warning |
They pass on Cygwin, but not on MSYS2 as intended.
|
@Berrysoft why unistd::sync was not added in this PR? it seems that it's present in libc |
|
I think I have checked most features, but sorry if I missed something... |
What does this PR do
This PR adds cygwin target support.
Tracking:
Checklist:
CONTRIBUTING.md