Conversation
Implement TCP_INFO option for getsockopt.
|
Hello, it looks like the CI is failing for two reasons:
The former is out of this PR's scope, so I won't address that here. However, I'd like advice on how to resolve the latter. Thank you! |
| libc::SO_EXCLBIND, | ||
| bool | ||
| ); | ||
| #[cfg(target_os = "linux")] |
There was a problem hiding this comment.
Hi there
However, I'd like advice on how to resolve the latter.
If uClibc has that symbol, you can add it to the libc crate. Otherwise, we need to filter it out:
| #[cfg(target_os = "linux")] | |
| #[cfg(all(target_os = "linux", not(target_env = "uclibc")))] |
There was a problem hiding this comment.
Added tcp_info to the uClibc symbols in libc: rust-lang/libc@4a34937. It looks like the CI still isn't happy though, do you know if that's because the libc change isn't published to crates.io yet?
There was a problem hiding this comment.
That PR rust-lang/libc#4347 added it to the main branch, Nix uses the libc-0.2 branch, so you need to ask the maintainer to backport it to this branch.
Once the backport PR gets merged, update the Cargo.toml file to use it from git:
Line 31 in ea012be
- libc = { version = "0.2.171", features = ["extra_traits"] }
+ libc = { git = "https://github.com/rust-lang/libc", rev = "the commit includes your libc PR", features = ... }There was a problem hiding this comment.
Got it, thanks! I'll update this PR when the change is backported.
There was a problem hiding this comment.
I'm a bit confused by this comment. The commit was backported to the 0.2 branch: rust-lang/libc@5a1f5f2. Why would pinning the version of the crate in the nix Cargo.toml file be the correct approach? I don't think that should get committed, right?
There was a problem hiding this comment.
Emm, I don't think I understand what you mean, could you please elaborate a bit?
Will be addressed in #2610 |
This reverts commit 7e6cd7e.
2 participants
Implement TCP_INFO option for getsockopt.
What does this PR do
Checklist:
CONTRIBUTING.md